chore: drop support for PHP 7.4 #7865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nitpick: 7.4 is EOL so this isn't a breaking change for a Nextcloud app as documented at https://docs.nextcloud.com/server/latest/developer_manual/app_publishing_maintenance/release_process.html#versioning We will not have to bump the major version number for this change. |
kesselb
force-pushed
the
chore/good-bye-php74
branch
2 times, most recently
from
d622439 to
93c3bde
Compare
kesselb
changed the title
kesselb
force-pushed
the
chore/good-bye-php74
branch
2 times, most recently
from
48a702d to
8baba6e
Compare
appinfo/info.xml
Outdated
| @@ -29,7 +29,7 @@ | |||
| <repository type="git">https://github.com/nextcloud/mail.git</repository> | |||
| <screenshot>https://user-images.githubusercontent.com/1374172/79554966-278e1600-809f-11ea-82ea-7a0d72a2704f.png</screenshot> | |||
| <dependencies> | |||
| <php min-version="7.4" max-version="8.1" /> | |||
| <php min-version="8.0" max-version="8.2" /> | |||
There was a problem hiding this comment.
your PR title didn't mention the sneaky addition of PHP8.2 support 😈
separate PR?
There was a problem hiding this comment.
True. Let me move it to another pr.
| @@ -29,7 +29,7 @@ | |||
| "christophwurst/kitinerary-flatpak": "^0.3", | |||
| "christophwurst/kitinerary-sys": "^0.2.0", | |||
| "ezyang/htmlpurifier": "4.16.0", | |||
| "gravatarphp/gravatar": "^2.0", | |||
| "gravatarphp/gravatar": "dev-master#6b9f6a45477ce48285738d9d0c3f0dbf97abe263", | |||
There was a problem hiding this comment.
gravatarphp/gravatar#17 is merged but not released 😞
gravatarphp/gravatar: Support for PHP 8 is merged but unreleased Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb
force-pushed
the
chore/good-bye-php74
branch
from
8baba6e to
e0b8311
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref nextcloud/groupware#41
Needs: