fix(talk_app): Also show reference previews for references with no pr…

…oper preview Signed-off-by: provokateurin <[email protected]>
nextcloud · Oct 31, 2024 · 33d8b7a · 33d8b7a
1 parent 05c8060
commit 33d8b7a
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 6 deletions.
diff --git a/packages/neon_framework/packages/talk_app/lib/src/widgets/message.dart b/packages/neon_framework/packages/talk_app/lib/src/widgets/message.dart
@@ -430,11 +430,10 @@ class _TalkCommentMessageState extends State<TalkCommentMessage> {
             if (parent != null) parent,
             text,
             for (final entry in references.entries.take(3))
-              if (entry.value.data?.openGraphObject.name != entry.key)
-                TalkReferencePreview(
-                  url: entry.key,
-                  openGraphObject: entry.value.data?.openGraphObject,
-                ),
+              TalkReferencePreview(
+                url: entry.key,
+                openGraphObject: entry.value.data?.openGraphObject,
+              ),
             if (!widget.isParent && widget.chatMessage.reactions.isNotEmpty)
               TalkReactions(
                 chatMessage: widget.chatMessage,

diff --git a/...work/packages/talk_app/test/goldens/message_comment_message_with_references.png b/...work/packages/talk_app/test/goldens/message_comment_message_with_references.png
diff --git a/packages/neon_framework/packages/talk_app/test/message_test.dart b/packages/neon_framework/packages/talk_app/test/message_test.dart
@@ -725,7 +725,7 @@ void main() {
 
       await tester.pumpAndSettle();
 
-      expect(find.byType(TalkReferencePreview), findsExactly(2));
+      expect(find.byType(TalkReferencePreview), findsExactly(3));
       for (final url in ['a', 'b']) {
         expect(
           find.byWidgetPredicate(
@@ -735,6 +735,13 @@ void main() {
           findsOne,
         );
       }
+      expect(
+        find.byWidgetPredicate(
+          (widget) =>
+              widget is TalkReferencePreview && widget.url == 'c' && widget.openGraphObject == brokenOpenGraphObject,
+        ),
+        findsOne,
+      );
 
       await expectLater(
         find.byType(TalkCommentMessage).first,