Merge pull request #1109 from nextcloud/feat/dynamite/config_add_line…

…length feat(dynamite): allow to configure the pageWidth for the dart formatter
nextcloud · Nov 4, 2023 · 7a6742e · 7a6742e
2 parents dca7c81 + d414214
commit 7a6742e
Show file tree

Hide file tree

Showing 6 changed files with 33 additions and 5 deletions.
diff --git a/packages/dynamite/dynamite/README.md b/packages/dynamite/dynamite/README.md
@@ -15,6 +15,7 @@ targets:
           # Options configure how source code is generated.
           #
           # The following are sensible default values that ignores the schemas for the coverage.
+          pageWidth: 120
           analyzer_ignores:
             - camel_case_types
             - discarded_futures

diff --git a/packages/dynamite/dynamite/lib/src/models/dynamite_config/config.dart b/packages/dynamite/dynamite/lib/src/models/dynamite_config/config.dart
@@ -30,6 +30,9 @@ abstract class DynamiteConfig implements Built<DynamiteConfig, DynamiteConfigBui
   /// All matches will be wrapped in `// coverage:ignore-start` and `// coverage:ignore-end` blocks.
   @BuiltValueField(wireName: 'coverage_ignores')
   BuiltSet<String>? get coverageIgnores;
+
+  /// The specified line with the formatter should use.
+  int? get pageWidth;
 }
 
 @SerializersFor([

diff --git a/packages/dynamite/dynamite/lib/src/models/dynamite_config/config.g.dart b/packages/dynamite/dynamite/lib/src/models/dynamite_config/config.g.dart
diff --git a/packages/dynamite/dynamite/lib/src/openapi_builder.dart b/packages/dynamite/dynamite/lib/src/openapi_builder.dart
@@ -86,7 +86,7 @@ class OpenAPIBuilder implements Builder {
         }
       }
 
-      final formatter = DartFormatter(pageWidth: 120);
+      final formatter = DartFormatter(pageWidth: buildConfig.pageWidth);
       await buildStep.writeAsString(
         outputId,
         formatter.format(outputString),

diff --git a/packages/dynamite/dynamite_end_to_end_test/build.yaml b/packages/dynamite/dynamite_end_to_end_test/build.yaml
@@ -5,6 +5,7 @@ targets:
         enabled: true
       dynamite:
         options:
+          pageWidth: 120
           analyzer_ignores:
             - camel_case_types
             - discarded_futures

diff --git a/packages/nextcloud/build.yaml b/packages/nextcloud/build.yaml
@@ -5,6 +5,7 @@ targets:
         enabled: true
       dynamite:
         options:
+          pageWidth: 120
           analyzer_ignores:
             - camel_case_types
             - discarded_futures