-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/neon/settings #1012
Refactor/neon/settings #1012
Conversation
64a4834
to
4c19b6b
Compare
I think that the entire idea of a separate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we don't forget those refactors
4c19b6b
to
b81ac02
Compare
f8d67d0
to
5c58520
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Select options are a bit broken because the currently selected value is not shown in the tile. Initially I thought you forgot to add it (I checked how it works in the settings on my phone) but it looks like you added it and it's just not working.
Is there an easy way to test the cupertino layout?
packages/neon/neon/lib/src/settings/widgets/settings_category.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/app/pubspec.lock is not updated
Just specify the platform in the theme. There are still bigger issues with the scaffold background color mismatching but as iOS is still a WIP I will address them separately. return ThemeData(
platform: TargetPlatform.iOS,
[...]
); |
Also because of some license issues with the apple font you will not be able to see the |
5c58520
to
a4e8a68
Compare
Signed-off-by: Nikolas Rimikis <[email protected]>
Signed-off-by: Nikolas Rimikis <[email protected]>
lol what. fucking apple... |
a4e8a68
to
08c6d21
Compare
handles the design part of #849
Changes to existing platforms:
SelecOption
s will now be handled in popup dialogs as it is common on m3The m3 docs themselves do not mention the modifications I made but I got inspired by the system settings on stock android