Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/neon/settings #1012

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Refactor/neon/settings #1012

merged 2 commits into from
Nov 2, 2023

Conversation

Leptopoda
Copy link
Member

@Leptopoda Leptopoda commented Oct 23, 2023

handles the design part of #849
Changes to existing platforms:

  • the visual density of the Settings will be higher on Linux than before
  • SelecOptions will now be handled in popup dialogs as it is common on m3
  • SettingsCategories will no longer be separated by a divider to match the m3 design

The m3 docs themselves do not mention the modifications I made but I got inspired by the system settings on stock android

@Leptopoda Leptopoda force-pushed the refactor/neon/settings branch 3 times, most recently from 64a4834 to 4c19b6b Compare October 29, 2023 15:53
@Leptopoda
Copy link
Member Author

Leptopoda commented Oct 29, 2023

I think that the entire idea of a separate SettingsListTile is bad.
Can we just remove it and provide normal widgets and helpers to style custom ones?

Copy link
Member Author

@Leptopoda Leptopoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1030 (comment)

So we don't forget those refactors

@Leptopoda Leptopoda force-pushed the refactor/neon/settings branch from 4c19b6b to b81ac02 Compare November 1, 2023 14:15
@Leptopoda Leptopoda force-pushed the refactor/neon/settings branch 2 times, most recently from f8d67d0 to 5c58520 Compare November 2, 2023 08:40
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Select options are a bit broken because the currently selected value is not shown in the tile. Initially I thought you forgot to add it (I checked how it works in the settings on my phone) but it looks like you added it and it's just not working.

Is there an easy way to test the cupertino layout?

.cspell/dart_flutter.txt Outdated Show resolved Hide resolved
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

packages/app/pubspec.lock is not updated

@Leptopoda
Copy link
Member Author

Is there an easy way to test the cupertino layout?

Just specify the platform in the theme. There are still bigger issues with the scaffold background color mismatching but as iOS is still a WIP I will address them separately.

    return ThemeData(
        platform: TargetPlatform.iOS,
        [...]
      );

@Leptopoda
Copy link
Member Author

Also because of some license issues with the apple font you will not be able to see the + icon in the add account tile unless you run it on iOS itself.

@Leptopoda Leptopoda force-pushed the refactor/neon/settings branch from 5c58520 to a4e8a68 Compare November 2, 2023 08:58
@provokateurin
Copy link
Member

Also because of some license issues with the apple font you will not be able to see the + icon in the add account tile unless you run it on iOS itself.

lol what. fucking apple...

@Leptopoda Leptopoda force-pushed the refactor/neon/settings branch from a4e8a68 to 08c6d21 Compare November 2, 2023 09:07
@Leptopoda Leptopoda merged commit a15fbb7 into main Nov 2, 2023
9 checks passed
@Leptopoda Leptopoda deleted the refactor/neon/settings branch November 2, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants