Fix/dynamite/header type resolver #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 25, 2023
provokateurin
requested changes
Oct 25, 2023
packages/dynamite/dynamite_end_to_end_test/lib/headers.openapi.json
Outdated
Show resolved
Hide resolved
Leptopoda
force-pushed
the
fix/dynamite/header_type_resolver
branch
from
65efb1a to
59574e7
Compare
|
I hope that we can sort the generated classes in the future to avoid such diffs. |
provokateurin
approved these changes
Oct 26, 2023
|
Maybe we should then first figure out how to prevent this diff? |
|
@provokateurin can I get a froce merge? The generation check for dynamite_e2e timed out and I already fix this in #1014 (which depends on this PR being merged) EDIT: we might need to find a different solution as the nextcloud tests didn't even run :/ |
This was referenced Oct 26, 2023
Signed-off-by: Nikolas Rimikis <[email protected]>
Signed-off-by: Nikolas Rimikis <[email protected]>
Leptopoda
force-pushed
the
fix/dynamite/header_type_resolver
branch
from
59574e7 to
3b6cbd9
Compare
Leptopoda
commented
Oct 27, 2023
Leptopoda
commented
Oct 27, 2023
packages/dynamite/dynamite/lib/src/builder/generate_schemas.dart
Outdated
Show resolved
Hide resolved
Signed-off-by: Nikolas Rimikis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a funny bug :)
We use generator functions where possible in dynamite for performance reasons. The problem is that they only get invoked lazily (when iterating). This means that they where only executed in the
addAllcode segment. BecausegenerateImportswas called before adding the code generated bygenerateClientswe where not taking the resolved types from these methods into account.an empty operationId caused our code to fail (fb01f7e)
We didn't hit it but we where calling
output.addfor the TypeDefs before we added the imports to the output meaning that we could potentially have code before the imports.