circumvent errors with dynamic or string arrays in oneOfs #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eOfs Signed-off-by: Nikolas Rimikis <[email protected]>
|
This might backfire because the problematic type might not be the last one but before the one that is actually correct. So we would need to treat oneOf as anyOf for now as the problem can still happen with this change. |
|
You are right. I didn't think about this. What about not trying to fix this issue in dynamite and just patch the spreed spec to be |
|
Hm yeah that sounds like a good idea. The same thing will also happen in server, but there it only affects two places which we don't even use right now. |
|
I've documented this issue in #1058 so I'll close this one for now. |
|
The branch can be deleted? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
required for #980
This is a hacks that just uses the first match in a oneOf to avoid failing when multiple values match.
In theory the normal built_value serializer does include the original type before in the serialized type but this is stripped when a
FullTypeis specified.I don't know yet how we can get access to this information with the
StandardJsonPluginenabled.I plan to investigate other methods and take these issues into consideration when working on #1049.