Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(neon,neon_files,neon_news,neon_notes): Fix notch clipping content #1068

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

provokateurin
Copy link
Member

Fixes #294
I tested with both the normal drawer and the always visible one and both work with this in portrait and landscape mode.

@Leptopoda
Copy link
Member

This does not fix the issue for other pages like the settings or the file info where it's fairly noticeable

@provokateurin
Copy link
Member Author

Ah I only fixed it for the main page because of the screenshot in the issue. I'll look into the other pages as well.

@Leptopoda
Copy link
Member

I'm not sure it'll work but maybe we can just wrap the entire material app with a safe area 🤔

@provokateurin
Copy link
Member Author

The problem is that then the status bar will be just black. We can do it, but apps usually don't do it.

@Leptopoda
Copy link
Member

Thinking about it some clients might want to display something full screen.
Like the video feed of talk in a call.

Maybe we can create a custom go_route like SafeAreaRoute that wraps the given page in a safe area?

@provokateurin
Copy link
Member Author

For other pages than those displayed in home we need to individually add the SafeArea. In Talk for example the call is on a new page that isn't rendered inside the home page, so there it wouldn't matter. I think we can just add the SafeArea to all the pages that need it and then we are good.

@provokateurin provokateurin force-pushed the fix/neon/notch-clipping branch from 17c7b87 to b5d18b6 Compare November 1, 2023 12:30
@provokateurin provokateurin changed the title fix(neon): Fix notch clipping content fix(neon,neon_files,neon_news,neon_notes): Fix notch clipping content Nov 1, 2023
@provokateurin
Copy link
Member Author

@Leptopoda Please review again

Copy link
Member

@Leptopoda Leptopoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should've done this earlier.
Such an easy fix xD

Thanks.

@provokateurin provokateurin merged commit b617373 into main Nov 1, 2023
9 checks passed
@provokateurin provokateurin deleted the fix/neon/notch-clipping branch November 1, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: neon clipping notch in landscape
2 participants