-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(neon,neon_files,neon_news,neon_notes): Fix notch clipping content #1068
Conversation
This does not fix the issue for other pages like the settings or the file info where it's fairly noticeable |
Ah I only fixed it for the main page because of the screenshot in the issue. I'll look into the other pages as well. |
I'm not sure it'll work but maybe we can just wrap the entire material app with a safe area 🤔 |
The problem is that then the status bar will be just black. We can do it, but apps usually don't do it. |
Thinking about it some clients might want to display something full screen. Maybe we can create a custom go_route like |
For other pages than those displayed in home we need to individually add the SafeArea. In Talk for example the call is on a new page that isn't rendered inside the home page, so there it wouldn't matter. I think we can just add the SafeArea to all the pages that need it and then we are good. |
Signed-off-by: jld3103 <[email protected]>
17c7b87
to
b5d18b6
Compare
@Leptopoda Please review again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should've done this earlier.
Such an easy fix xD
Thanks.
Fixes #294
I tested with both the normal drawer and the always visible one and both work with this in portrait and landscape mode.