Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(dynamite_end_to_end_test): test problematic ofs #1100

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

Leptopoda
Copy link
Member

Adds basic tests to the ofs schemas.
I added all scenarios I consider problematic and where I want to work on in the coming weeks (namely #1082 and #1049) minus the allOf issues I found (#1098 and #1099).
Arrays are also still untested and left for #1056 and #1058.

I also still left out unit tests for the generated code as I will first want to implement the changes.
After this we can also unit test the generated code to help us keep a stable api within the generated code.

Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to add tests before trying to change stuff!

@Leptopoda Leptopoda enabled auto-merge November 3, 2023 22:21
@Leptopoda Leptopoda merged commit 9bc1ebe into main Nov 3, 2023
9 checks passed
@Leptopoda Leptopoda deleted the test/dynamite_e2e/add_ofs_tests branch November 3, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants