Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dynamite,nextcloud): fix generics in nested built_collection buil… #1129

Merged
merged 1 commit into from
Nov 13, 2023
Merged

fix(dynamite,nextcloud): fix generics in nested built_collection buil… #1129

merged 1 commit into from
Nov 13, 2023

Conversation

Leptopoda
Copy link
Member

No description provided.

@Leptopoda Leptopoda mentioned this pull request Nov 12, 2023
Merged
@Leptopoda Leptopoda force-pushed the fix/dynamite/nested_built_collection_builder branch 2 times, most recently from 747abf2 to e41db38 Compare November 12, 2023 17:24
@Leptopoda Leptopoda force-pushed the fix/dynamite/nested_built_collection_builder branch from e41db38 to 49abaec Compare November 13, 2023 07:18
provokateurin
provokateurin approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to also add a test to the e2e tests? Just so we can more easily see if there are changes in the future (although you already cover that in the unit tests so we should be fine).

@Leptopoda
Copy link
Member Author

We wouldn't really catch the issue in dynamite_e2e.
But it's already on my list to add further tests there.

@Leptopoda Leptopoda merged commit b76745d into main Nov 13, 2023
9 checks passed
@Leptopoda Leptopoda deleted the fix/dynamite/nested_built_collection_builder branch November 13, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@provokateurin provokateurin provokateurin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Leptopoda @provokateurin