Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dynamite_petstore_example): Init #1137

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

provokateurin
Copy link
Member

@provokateurin provokateurin commented Nov 14, 2023

Depends on #1136
#761

@provokateurin provokateurin changed the title fix(dynamite): Fix application/octet-stream encoding feat(dynamite_petstore_example): Init Nov 14, 2023
@provokateurin
Copy link
Member Author

@Leptopoda I can move the fix for the security schemes to a separate PR. With the applied patch it is not necessary anyway since it doesn't break this PR.

@provokateurin provokateurin force-pushed the feature/dynamite/petstore-example branch 2 times, most recently from e66e38a to dc6705f Compare November 14, 2023 07:10
Copy link
Member

@Leptopoda Leptopoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also open followup issues for:

  • the authentication issue
  • to test the petstore against the server

packages/dynamite/dynamite/lib/src/builder/client.dart Outdated Show resolved Hide resolved
@provokateurin
Copy link
Member Author

yq is failing because of different implementations... I'll find a solution for that

@provokateurin
Copy link
Member Author

I'm now using the petstore specification from https://github.com/OAI/OpenAPI-Specification which doesn't have the authentication problems and doesn't need any patching or yq magic.

@provokateurin provokateurin force-pushed the feature/dynamite/petstore-example branch from f242f30 to 6de2061 Compare November 16, 2023 07:44
@provokateurin provokateurin marked this pull request as ready for review November 16, 2023 07:45
@Leptopoda
Copy link
Member

Be aware that this uses the utf8 codec so #1143 is conflicting.
I suggest landing the flutter upgrade first

@provokateurin provokateurin force-pushed the feature/dynamite/petstore-example branch from 6de2061 to 3e5e53f Compare November 16, 2023 17:38
@provokateurin provokateurin merged commit 4abf172 into main Nov 16, 2023
9 checks passed
@provokateurin provokateurin deleted the feature/dynamite/petstore-example branch November 16, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants