Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dynamite)!: allow clients from the http package #1448

Merged
merged 2 commits into from
Jan 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/app/pubspec.lock
Original file line number Diff line number Diff line change
Expand Up @@ -481,10 +481,10 @@ packages:
dependency: transitive
description:
name: http
sha256: d4872660c46d929f6b8a9ef4e7a7eff7e49bbf0c4ec3f385ee32df5119175139
sha256: a2bbf9d017fcced29139daa8ed2bba4ece450ab222871df93ca9eec6f80c34ba
url: "https://pub.dev"
source: hosted
version: "1.1.2"
version: "1.2.0"
http_parser:
dependency: transitive
description:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ class $Client extends _i2.DynamiteClient {
$Client(
super.baseURL, {
super.baseHeaders,
super.userAgent,
super.httpClient,
super.cookieJar,
});
Expand Down
6 changes: 0 additions & 6 deletions packages/dynamite/dynamite/lib/src/builder/client.dart
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,6 @@ Class buildRootClient(
..toSuper = true
..named = true,
),
Parameter(
(b) => b
..name = 'userAgent'
..toSuper = true
..named = true,
),
Parameter(
(b) => b
..name = 'httpClient'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ final dependencies = {
'built_value': Version.parse('8.0.0'),
'collection': Version.parse('1.0.0'),
'dynamite_runtime': Version.parse('0.1.0'),
'http': Version.parse('1.2.0'),
'meta': Version.parse('1.0.0'),
'uri': Version.parse('1.0.0'),
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ class $Client extends _i1.DynamiteClient {
$Client(
super.baseURL, {
super.baseHeaders,
super.userAgent,
super.httpClient,
super.cookieJar,
super.authentications,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ class $Client extends _i2.DynamiteClient {
$Client(
super.baseURL, {
super.baseHeaders,
super.userAgent,
super.httpClient,
super.cookieJar,
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ class $Client extends _i1.DynamiteClient {
$Client(
super.baseURL, {
super.baseHeaders,
super.userAgent,
super.httpClient,
super.cookieJar,
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ class $Client extends _i3.DynamiteClient {
$Client(
super.baseURL, {
super.baseHeaders,
super.userAgent,
super.httpClient,
super.cookieJar,
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ class $Client extends _i1.DynamiteClient {
$Client(
super.baseURL, {
super.baseHeaders,
super.userAgent,
super.httpClient,
super.cookieJar,
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ class $Client extends _i1.DynamiteClient {
$Client(
super.baseURL, {
super.baseHeaders,
super.userAgent,
super.httpClient,
super.cookieJar,
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ class $Client extends _i1.DynamiteClient {
$Client(
super.baseURL, {
super.baseHeaders,
super.userAgent,
super.httpClient,
super.cookieJar,
});
Expand Down
3 changes: 1 addition & 2 deletions packages/dynamite/dynamite_end_to_end_test/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,16 @@ dependencies:
built_value: ^8.0.0
collection: ^1.0.0
dynamite_runtime: ^0.1.0
http: ^1.2.0
meta: ^1.0.0
uri: ^1.0.0

dev_dependencies:
build_runner: ^2.4.8
built_value_generator: ^8.8.1
dynamite: ^0.1.0
mockito: ^5.4.4
neon_lints:
git:
url: https://github.com/nextcloud/neon
path: packages/neon_lints
test: ^1.25.1
universal_io: ^2.2.2
Loading