-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(nextcloud)!: Migrate to DAV v2 endpoint for WebDAV #2557
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2557 +/- ##
=======================================
Coverage 28.79% 28.79%
=======================================
Files 370 370
Lines 136490 136496 +6
=======================================
+ Hits 39296 39300 +4
- Misses 97194 97196 +2
*This pull request uses carry forward flags. Click here to find out more.
|
What we could do alternatively is to require the username to be passed when creating the WebDavClient. That would be a bit cleaner as then all the http.Request getters can be sync and we avoid doing a network request (since the consumer of the package might already know the username anyway like we do in Neon). |
This is also exactly what I thought. |
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
1185498
to
af1f3d3
Compare
We could add an extension in the framework that would allow us to still call |
Replaces #2306
Should help with #2308 and #718 as those require using the v2 endpoints.