feat(neon_lints): upgrade lints #2707
Conversation
Signed-off-by: Nikolas Rimikis <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2707 +/- ##
=======================================
Coverage 28.90% 28.90%
=======================================
Files 373 373
Lines 136645 136645
=======================================
Hits 39498 39498
Misses 97147 97147
*This pull request uses carry forward flags. Click here to find out more. |
| use_test_throws_matchers: true | ||
| use_to_and_as_if_applicable: true | ||
| valid_regexps: true | ||
| void_checks: true | ||
| avoid_as: false | ||
| no_default_cases: false |
There was a problem hiding this comment.
I like this one, can we enable it?
There was a problem hiding this comment.
Ah I just saw we already had it above, but also disabled 🤔
| use_named_constants: true | ||
| use_raw_strings: true | ||
| use_rethrow_when_possible: true | ||
| use_setters_to_change_properties: true | ||
| use_string_buffers: true | ||
| use_string_in_part_of_directives: true | ||
| use_super_parameters: true |
There was a problem hiding this comment.
This was already helpful in the past, so I'd like to keep it enabled
| @@ -219,16 +211,15 @@ linter: | |||
| use_if_null_to_convert_nulls_to_bools: true | |||
| use_is_even_rather_than_modulo: true | |||
| use_key_in_widget_constructors: true | |||
| use_late_for_private_fields_and_variables: true | |||
There was a problem hiding this comment.
This makes sense to me, can we keep it?
| @@ -209,7 +202,6 @@ linter: | |||
| unnecessary_to_list_in_spreads: true | |||
| unreachable_from_main: true | |||
| unrelated_type_equality_checks: true | |||
| unsafe_html: true | |||
There was a problem hiding this comment.
I did fix these issues, so we should be able to keep this rule?
There was a problem hiding this comment.
This one is actually deprecated and removed in dart 3.7
There was a problem hiding this comment.
Interesting, it was only added so recently 😅
| @@ -196,7 +190,6 @@ linter: | |||
| unnecessary_new: true | |||
| unnecessary_null_aware_assignments: true | |||
| unnecessary_null_aware_operator_on_extension_on_nullable: true | |||
| unnecessary_null_checks: true | |||
There was a problem hiding this comment.
Also makes sense to me, can we keep it?
| @@ -14,7 +14,6 @@ linter: | |||
| always_specify_types: false | |||
| always_use_package_imports: true | |||
| annotate_overrides: true | |||
| annotate_redeclares: true | |||
There was a problem hiding this comment.
I think this is important for extension types?
| exhaustive_cases: true | ||
| file_names: true | ||
| flutter_style_todos: true | ||
| hash_and_equals: true | ||
| implementation_imports: true | ||
| implicit_call_tearoffs: true | ||
| implicit_reopen: true |
There was a problem hiding this comment.
Seems important for the new class modifiers
This might need some discussion.
Why are some rules disabled?
lint_makernow skipps experimental lints.TBH this was an oversight on my side as I didn't think about neon when making the change.
Do we want to enable experimental rules?
use_super_parametersfor example, is experimental but also recommended. We didn't ever encounter any issues with this rule, and it has a quick fix available.unsafe_htmlraised some false positives so I'd like to not enable this one.https://dart.dev/tools/linter-rules/use_super_parameters