Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ios): Added ios support to existing project #755

Closed

Conversation

warmachinesocial
Copy link

I have created the issue #754 and this is the PR however please let me know about the commit message I don't know if it's correct or not.

@Leptopoda
Copy link
Member

Leptopoda commented Sep 9, 2023

The part in the brackets should resemble the package you have changed.
At a quick glance looks like you should have use both app and neon, becoming something like:
feat(app,neon): initial iOS support

We also have sort of commit linting wich should have been activated by the ./tool/setup.sh script if run by you.
running dart run husky install would install it without running the setup script (although I don't see a reason not to run the script).
This will install a git hook to the local clone and whenever you commit the hook should be executed informing you whether you did it right (You mentioned to use a graphical git app. I don't know whether it supports this).

Finally please also signoff your commits. this can be done by using git commit -s (again might be different in a gui). The logs of the failed DCO check also talks you through that.

@Leptopoda Leptopoda self-assigned this Sep 9, 2023
Copy link
Member

@Leptopoda Leptopoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial feedback. If you have the time you can also think about adding iOS support to the separate neon apps (neon_files, neon_news and neon_notes).
We should also evaluate how we can best tackle the notifications support..

Please understand that we are not going to merge this PR until we have a working iOS development setup and gathered some knowledge on how to do iOS flutter development. We are currently also involved in many other issues and short on time so please be patient.

tool/dev.sh Outdated Show resolved Hide resolved
packages/neon/neon/lib/l10n/localizations_en.dart Outdated Show resolved Hide resolved
packages/app/test/widget_test.dart Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong icon.

We currently have a custom script generating them but will probably change it in #447

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So should just remove the icons? Where is the script?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's currently in tool/generate-assets.sh.

packages/app/.metadata Outdated Show resolved Hide resolved
@provokateurin
Copy link
Member

@nishp77 Can you make sure that your branch is rebased onto the latest main branch? I see a lot of changes that are already in our main branch (I'm not sure exactly why the show up here).

@Leptopoda Leptopoda linked an issue Sep 10, 2023 that may be closed by this pull request
7 tasks
@warmachinesocial warmachinesocial force-pushed the feature/ios branch 2 times, most recently from 65b807d to e861850 Compare September 11, 2023 22:58
@provokateurin
Copy link
Member

@nishp77 do you plan on continuing this? Do you need some help with it? Afaik @Leptopoda has access to a Mac now, so you two could work on it together.

@Leptopoda
Copy link
Member

I think the only thing missing was hooking it up to the icon generation script.
Other than that I tested this PR on an iOS emulator and it was working just fine.

Once I have more time I'll test it on some physical iOS devices and test all of our functionality but other than the mentioned notifications issue this should be all.

When I checked out the PR I also noticed minor missing things like the package ID being wrong but that should also not be a big problem :)

@warmachinesocial
Copy link
Author

Sorry guys got busy because I was away I will starting working back again on this...

@Leptopoda Leptopoda marked this pull request as draft November 2, 2023 09:00
@Leptopoda Leptopoda added the help wanted Extra attention is needed label Nov 20, 2023
@Leptopoda Leptopoda force-pushed the feature/ios branch 2 times, most recently from b44c583 to 182e548 Compare February 19, 2024 16:35
@@ -0,0 +1,12 @@
#!/bin/sh
# This is a generated file; do not edit or check into version control.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Signed-off-by: Nish <[email protected]>
Signed-off-by: Nish Patel <[email protected]>
Signed-off-by: Nikolas Rimkis <[email protected]>
@Leptopoda
Copy link
Member

I'm going to close this for now and keep the branch locally.
It currently isn't our priority and I do not have the capacity to maintain iOS at this point of time.

@Leptopoda Leptopoda closed this Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed platform: ios
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for IOS
3 participants