feat(neon_files): Implement sharing file natively #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
force-pushed
the
feature/share-file-native
branch
from
7415278 to
4a9754a
Compare
|
I'd rather implement this after #803 in a cleaner way without the cache potentially growing forever |
provokateurin
force-pushed
the
feature/share-file-native
branch
from
4a9754a to
b81438c
Compare
|
@Leptopoda can we please just merge this? The current code that "syncs" a file already uses this logic, so adding this small feature which reuses most of that logic is not too bad imo. I understand that we should do this in a better way, but it's also not great to keep this PR around forever until we have the cleaner way. |
Leptopoda
approved these changes
Sep 28, 2023
Signed-off-by: jld3103 <[email protected]>
provokateurin
force-pushed
the
feature/share-file-native
branch
from
b81438c to
3f20a32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #42