Refactor nextcloud package exports #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
force-pushed
the
refactor/nextcloud/exports
branch
from
01308fe to
efb724a
Compare
Signed-off-by: jld3103 <[email protected]>
Signed-off-by: jld3103 <[email protected]>
provokateurin
force-pushed
the
refactor/nextcloud/exports
branch
from
efb724a to
83cf658
Compare
…and app IDs Signed-off-by: jld3103 <[email protected]>
provokateurin
force-pushed
the
refactor/nextcloud/exports
branch
from
83cf658 to
fe7331c
Compare
|
@Leptopoda please review again :) |
Leptopoda
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits all the exports into separate files.
Moves the supported check to the app implementations to prevent importing the respective APIs in the core.
Also generates the app IDs. They are still not implemented as an enum since enum can't be used in consts yet (although there has been a fix in the Dart SDK already).
Sadly this doesn't reduce the app size at all (which was my initial goal), but I still think that it improves the structure quite a lot (also because we now won't forget to export something).
Closes #796
Partially addresses #794