-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(push): Add option to send a self-test #2109
Conversation
428e2a2
to
cbb28ea
Compare
cbb28ea
to
43b1ca4
Compare
43b1ca4
to
aa7dcb0
Compare
Signed-off-by: Joas Schilling <[email protected]>
aa7dcb0
to
85fe878
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and work 👍
Should we rate limit that endpoint? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! But I agree with @SystemKeeper
Had discussed earlier already, that there are many other points we would need to ratelimit to avoid a problem here (e.g. create a public conversation and mention yourself, create a public share, set activity to push on upload and bombard yourself). And at the same time, we might want to have a temporary high frequency here anyway. I would only imagine something like 60 per hour? |
Fix #1206