Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(push): Add option to send a self-test #2109

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Nov 29, 2024

Fix #1206


grafik

@nickvergessen nickvergessen force-pushed the feat/1206/self-test-push branch from aa7dcb0 to 85fe878 Compare November 29, 2024 14:18
@nickvergessen nickvergessen self-assigned this Nov 29, 2024
@nickvergessen nickvergessen marked this pull request as ready for review November 29, 2024 14:21
Copy link
Member

@Ivansss Ivansss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and work 👍

@SystemKeeper
Copy link
Contributor

Should we rate limit that endpoint?

Copy link

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! But I agree with @SystemKeeper

@nickvergessen
Copy link
Member Author

Had discussed earlier already, that there are many other points we would need to ratelimit to avoid a problem here (e.g. create a public conversation and mention yourself, create a public share, set activity to push on upload and bombard yourself).

And at the same time, we might want to have a temporary high frequency here anyway. I would only imagine something like 60 per hour?

@nickvergessen nickvergessen merged commit db651ff into master Dec 2, 2024
46 checks passed
@nickvergessen nickvergessen deleted the feat/1206/self-test-push branch December 2, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

trigger "notification:test-push" via mobile apps (to self test push notifications)
4 participants