Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app-nav-btn): fixed relative right position on small screens #2285

Conversation

emoral435
Copy link
Contributor

☑️ Resolves #2278

🖼️ Screenshots

🏚️ Before 🏡 After
image firefox_wvFkVmkwwi

🚧 Summary

  • When the viewport got small in the photos app, the app-navigation-button overflowed to the right of the screen, becoming inaccessible
  • To fix this, since the button is positioned relative to the header, I removed some of the negative right positioning on the button

This allows the button to still be in view, while a little tight, and also still allows it to be found with keyboard navigation 👍
Any styling choices can be commented on !

Checklist

Code is properly formatted

Sign-off message is added to all commits

[ ] Tests (unit, integration, api and/or acceptance) are included

[x] Screenshots before/after for front-end changes

[x] Documentation (manuals or wiki) has been updated or is not required

[x] Backports requested where applicable (ex: critical bugfixes)

@emoral435 emoral435 added bug Something isn't working 3. to review Waiting for reviews accessibility labels Jan 25, 2024
@emoral435 emoral435 added this to the Nextcloud 29 milestone Jan 25, 2024
@emoral435 emoral435 self-assigned this Jan 25, 2024
@emoral435
Copy link
Contributor Author

For the reviewers - no worries, only one file got changed, and it was a minor change 👀 not some scary 29-file PR

Copy link
Collaborator

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be fixed in @nc/vue?

@emoral435
Copy link
Contributor Author

Full transparency - did not know that this was a component within NcVue 👀 but I found it right now, will be changing that! Closing this PR and submitting this change there 👍

Copy link
Contributor

github-actions bot commented May 3, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews accessibility bug Something isn't working feedback-requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BITV]: Not possible to close left sidebar on small screens
2 participants