Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh(a11y): Fix modal close button overlapping content #2297

Merged
merged 2 commits into from
Feb 1, 2024
Merged

enh(a11y): Fix modal close button overlapping content #2297

merged 2 commits into from
Feb 1, 2024

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Jan 31, 2024

@Pytal Pytal added 3. to review Waiting for reviews accessibility labels Jan 31, 2024
@Pytal Pytal added this to the Nextcloud 29 milestone Jan 31, 2024
@Pytal Pytal self-assigned this Jan 31, 2024
@Pytal
Copy link
Member Author

Pytal commented Jan 31, 2024

/compile /

@Pytal
Copy link
Member Author

Pytal commented Jan 31, 2024

/backport to stable28

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Jan 31, 2024
@nextcloud-command
chore(assets): Recompile assets
6976a88 
Signed-off-by: nextcloud-command <[email protected]>
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 1, 2024
@Pytal Pytal enabled auto-merge February 1, 2024 17:16
@Pytal Pytal disabled auto-merge February 1, 2024 18:13
@Pytal Pytal enabled auto-merge February 1, 2024 18:14
@Pytal Pytal merged commit 1c0bf8f into master Feb 1, 2024
23 checks passed
@Pytal Pytal deleted the enh/a11y/modal-to-dialog branch February 1, 2024 18:33
@backportbot backportbot bot mentioned this pull request Feb 1, 2024
Merged
2 tasks
@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label Feb 1, 2024
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emoral435 emoral435 emoral435 approved these changes

@artonge artonge artonge approved these changes

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@susnux susnux susnux approved these changes

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.
6 participants
@Pytal @susnux @JuliaKirschenheuter @artonge @emoral435 @nextcloud-command