Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use blurhash as preview #2375

Merged
merged 4 commits into from
Mar 7, 2024
Merged

Use blurhash as preview #2375

merged 4 commits into from
Mar 7, 2024

Conversation

artonge
Copy link
Collaborator

@artonge artonge commented Mar 6, 2024 •
edited
Loading

Changes

  • Feat: Use blurhash as a quit preview while fetching actual previews
  • Fix: Reset File.vue when file is updated
  • Perf: Add hot cache to PreviewService

Screencasts

The user sees feedback faster on initial load. This would be even more pronounced on slow network

Before

Screencast.from.2024-03-06.17-47-41.webm

After

Screencast.from.2024-03-06.17-44-21.webm

Less flicking after the first fast scroll

Before

Screencast.from.2024-03-06.17-45-15.webm

After

Screencast.from.2024-03-06.17-48-02.webm

@artonge artonge self-assigned this Mar 6, 2024
@artonge artonge added the 2. developing Work in progress label Mar 6, 2024
@artonge artonge force-pushed the artonge/feat/blurhash branch 2 times, most recently from 8b62754 to 28b69b6 Compare March 6, 2024 16:47
@artonge artonge added 3. to review Waiting for reviews javascript Javascript related ticket performances Performances issues and optimisations and removed 2. developing Work in progress labels Mar 6, 2024
@artonge artonge added this to the Nextcloud 29 milestone Mar 6, 2024
@artonge artonge requested a review from skjnldsv March 6, 2024 16:54
@artonge artonge marked this pull request as ready for review March 6, 2024 16:54
@artonge artonge changed the title Add blurhash Use blurhash as preview Mar 6, 2024
@artonge artonge force-pushed the artonge/feat/blurhash branch 2 times, most recently from a184915 to ee7f2f8 Compare March 7, 2024 10:57
@artonge artonge requested a review from susnux March 7, 2024 11:20
@artonge
chore: Compile assets
7edd2b1 
Signed-off-by: Louis Chemineau <[email protected]>
@artonge artonge force-pushed the artonge/feat/blurhash branch from ee7f2f8 to 7edd2b1 Compare March 7, 2024 11:22
susnux
susnux approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works but see comment, might make life later easier and reduces logic code a bit.

@artonge artonge merged commit 4cbae20 into master Mar 7, 2024
23 checks passed
@artonge artonge deleted the artonge/feat/blurhash branch March 7, 2024 13:26
@blizzz blizzz mentioned this pull request Mar 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@artonge artonge

Labels
3. to review Waiting for reviews javascript Javascript related ticket performances Performances issues and optimisations
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.
2 participants
@artonge @susnux