Add support for ignoring folders with .nomedia and .noimage #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonjomckay
force-pushed
the
add-support-for-ignoring-folders
branch
from
afda633 to
39ee18d
Compare
Signed-off-by: Jonjo McKay <[email protected]>
jonjomckay
force-pushed
the
add-support-for-ignoring-folders
branch
from
39ee18d to
368c023
Compare
|
One thing I'm not sure about - should I add |
szaimen
added
3. to review
|
FYI regarding this pull request since @marcelklehr you also opened one regarding .nomedia filtering. cc @skjnldsv |
|
@jonjomckay I only see event listeners for the nomedia bookkeeping in the code. How does this PR deal with already existing files? |
|
I think this can be closed, as #944 got merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses an event listener to record the paths of folders that contain a
.nomediaor.noimage, and stores them as "excluded paths" in the database.These excluded paths are then used to filter the view appropriately. Performing the filtering in the view is quite naive, but seems to be the best way for now, due to the limitations of using the WebDAV
searchrequestfunction. If the app ends up moving to an app-specific API in the view, these paths can be used easily in the server-side API method, as they are.Creation of an "included paths" table with the same schema is also included, which could be used to implement #141.
This is my first PR against anything Nextcloud-related, so let me know if I need to change anything!
This should fix #203, #234, #245, #537, #903 and #908.