Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid error when app not installed #454

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

jmcclelland
Copy link
Contributor

Fixes #362

@Pytal Pytal requested a review from ArtificialOwl July 18, 2024 16:16
Copy link

github-actions bot commented Aug 1, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@joshtrichards joshtrichards added 3. to review Waiting for reviews bug Something isn't working labels Dec 10, 2024
@joshtrichards
Copy link
Member

joshtrichards commented Dec 10, 2024

This would certainly help, but I think the root cause is the NcRelatedResourcesPanel component usage in the Contacts app:

https://github.com/nextcloud/contacts/blob/7a6a92af3b994fea8637bfe7eeaef9573ecd2dbe/src/components/ContactDetails.vue#L292

It was added in nextcloud/contacts#3670.

Cc: @Pytal & @GretaD

@Pytal
Copy link
Member

Pytal commented Dec 10, 2024

Not familiar with contacts but on a quick look at the code the fix seems to be checking if the respective app for each resource-type is enabled before attempting to render it, cc @GretaD

@GretaD
Copy link
Contributor

GretaD commented Dec 11, 2024

thanks a lot for the contribution. Please sign your commit and we can merge it :)

@jmcclelland
Copy link
Contributor Author

@GretaD Great - I just pushed my signature. Do you want me to rebase or merge-commit?

@GretaD
Copy link
Contributor

GretaD commented Dec 11, 2024

i think you just need to do:

In your local branch, run: git rebase HEAD~1 --signoff
Force push your changes to overwrite the branch: git push --force-with-lease origin not-found

Signed-off-by: Jamie McClelland <[email protected]>
@jmcclelland
Copy link
Contributor Author

@GretaD thanks - I just made the changes. Let me know if there is anything else for me to do.

@GretaD GretaD merged commit 6530d58 into nextcloud:master Dec 13, 2024
21 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feedback-requested
Projects
None yet
4 participants