-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
avoid error when app not installed #454
Conversation
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
This would certainly help, but I think the root cause is the It was added in nextcloud/contacts#3670. |
Not familiar with contacts but on a quick look at the code the fix seems to be checking if the respective app for each |
thanks a lot for the contribution. Please sign your commit and we can merge it :) |
4406e43
to
44bd789
Compare
@GretaD Great - I just pushed my signature. Do you want me to rebase or merge-commit? |
i think you just need to do: In your local branch, run: |
Signed-off-by: Jamie McClelland <[email protected]>
44bd789
to
52e375f
Compare
@GretaD thanks - I just made the changes. Let me know if there is anything else for me to do. |
Fixes #362