-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update file metadata after save #3230
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
force-pushed
the
bugfix/noid/vue-update-timestamp
branch
from
October 17, 2023 08:24
73a1b8b
to
3a6fc4c
Compare
15 failed tests on run #667 ↗︎
Details:
Review all test suite changes for PR #3230 ↗︎ |
CI failures look related to broken viewer - pushing nextcloud/viewer#2006 |
juliusknorr
force-pushed
the
bugfix/noid/vue-update-timestamp
branch
from
October 17, 2023 10:28
3a6fc4c
to
6bdb647
Compare
max-nextcloud
approved these changes
Oct 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. Did not test it though.
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
bugfix/noid/vue-update-timestamp
branch
from
October 18, 2023 15:28
6bdb647
to
6e9ab48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Track the state of the document modification status through the incoming post messages to make sure that we only update the mtime displayed in the file list if the file was actually changed.
Also introduce handling for the new F2V file metadata and emit events on save.
Manual backport is in #3231