Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: startPresentation URL parameter #4209

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

elzody
Copy link
Contributor

@elzody elzody commented Nov 7, 2024

Summary

TODO

  • Cypress tests?

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

@elzody elzody added enhancement New feature or request 2. developing Work in progress labels Nov 7, 2024
@elzody elzody self-assigned this Nov 7, 2024
@elzody elzody changed the title Feat/start presentation parameter feat: startPresentation URL parameter Nov 7, 2024
src/helpers/url.js Outdated Show resolved Hide resolved
@elzody elzody force-pushed the feat/start-presentation-parameter branch from 0dfd12e to 99fca49 Compare November 7, 2024 19:16
@elzody
Copy link
Contributor Author

elzody commented Nov 19, 2024

i briefly spoke with méven from collabora in the matrix chat about this, and this was the response:

That's the current expected behavior, due to browser limitation, we can't open a real external presentation window so COOL is replaced by the presentation logic, this could be worked-around though. Browsers have added more restriction since the feature was implemented, this would need to be fixed for certain browsers

therefore, at least for now, given having to refresh the page, this should work
cc: @juliusknorr

@juliusknorr
Copy link
Member

All right, then let's stick with that as intended behavior

@elzody elzody force-pushed the feat/start-presentation-parameter branch from 99fca49 to d3fa91f Compare November 20, 2024 20:44
@juliusknorr
Copy link
Member

Not sure if anything still left as it is in work in progress state still, but looks good from my side 👍

@elzody elzody marked this pull request as ready for review November 21, 2024 14:28
@elzody elzody merged commit 1cfedbc into main Nov 21, 2024
74 checks passed
@elzody elzody deleted the feat/start-presentation-parameter branch November 21, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable startPresentation parameter
2 participants