Skip to content

[RFC] Refactor image handling #47097

[RFC] Refactor image handling

[RFC] Refactor image handling #47097

Triggered via pull request August 16, 2024 09:45
Status Failure
Total duration 21m 45s
Artifacts

static-code-analysis.yml

on: pull_request
static-code-analysis
4m 50s
static-code-analysis
static-code-analysis-security
15m 46s
static-code-analysis-security
static-code-analysis-ocp
2m 53s
static-code-analysis-ocp
Fit to window
Zoom out
Zoom in

Annotations

20 errors
UndefinedVariable: lib/private/Image/Gd.php#L61
lib/private/Image/Gd.php:61:44: UndefinedVariable: Cannot find referenced variable $resource (see https://psalm.dev/024)
InvalidArgument: lib/private/Image/Gd.php#L73
lib/private/Image/Gd.php:73:21: InvalidArgument: Argument 1 of imagesx expects GdImage, but bool|object|resource provided (see https://psalm.dev/004)
RedundantCondition: lib/private/Image/Gd.php#L74
lib/private/Image/Gd.php:74:8: RedundantCondition: int can never contain false (see https://psalm.dev/122)
InvalidArgument: lib/private/Image/Gd.php#L86
lib/private/Image/Gd.php:86:22: InvalidArgument: Argument 1 of imagesy expects GdImage, but bool|object|resource provided (see https://psalm.dev/004)
RedundantCondition: lib/private/Image/Gd.php#L87
lib/private/Image/Gd.php:87:8: RedundantCondition: int can never contain false (see https://psalm.dev/122)
InvalidArgument: lib/private/Image/Gd.php#L124
lib/private/Image/Gd.php:124:24: InvalidArgument: Argument 1 of imagegif expects GdImage, but bool|object|resource provided (see https://psalm.dev/004)
InvalidArgument: lib/private/Image/Gd.php#L127
lib/private/Image/Gd.php:127:25: InvalidArgument: Argument 1 of imagejpeg expects GdImage, but bool|object|resource provided (see https://psalm.dev/004)
InvalidArgument: lib/private/Image/Gd.php#L130
lib/private/Image/Gd.php:130:24: InvalidArgument: Argument 1 of imagepng expects GdImage, but bool|object|resource provided (see https://psalm.dev/004)
InvalidArgument: lib/private/Image/Gd.php#L134
lib/private/Image/Gd.php:134:25: InvalidArgument: Argument 1 of imagexbm expects GdImage, but bool|object|resource provided (see https://psalm.dev/004)
InvalidArgument: lib/private/Image/Gd.php#L141
lib/private/Image/Gd.php:141:25: InvalidArgument: Argument 1 of imagewbmp expects GdImage, but bool|object|resource provided (see https://psalm.dev/004)
TaintedHtml: apps/admin_audit/lib/Actions/Action.php#L42
apps/admin_audit/lib/Actions/Action.php:42:16: TaintedHtml: Detected tainted HTML (see https://psalm.dev/245)
TaintedCallable: apps/files_external/lib/Config/ConfigAdapter.php#L52
apps/files_external/lib/Config/ConfigAdapter.php:52:50: TaintedCallable: Detected tainted text (see https://psalm.dev/243)
TaintedFile: apps/files_external/lib/Lib/Storage/SFTP.php#L384
apps/files_external/lib/Lib/Storage/SFTP.php:384:22: TaintedFile: Detected tainted file handling (see https://psalm.dev/255)
TaintedCookie: apps/files_sharing/lib/Controller/ShareController.php#L430
apps/files_sharing/lib/Controller/ShareController.php:430:35: TaintedCookie: Detected tainted cookie (see https://psalm.dev/257)
TaintedFile: apps/theming/lib/IconBuilder.php#L116
apps/theming/lib/IconBuilder.php:116:40: TaintedFile: Detected tainted file handling (see https://psalm.dev/255)
TaintedFile: apps/theming/lib/IconBuilder.php#L214
apps/theming/lib/IconBuilder.php:214:28: TaintedFile: Detected tainted file handling (see https://psalm.dev/255)
TaintedHeader: lib/base.php#L144
lib/base.php:144:12: TaintedHeader: Detected tainted header (see https://psalm.dev/256)
TaintedHeader: lib/base.php#L226
lib/base.php:226:12: TaintedHeader: Detected tainted header (see https://psalm.dev/256)
TaintedFile: lib/private/App/InfoParser.php#L38
lib/private/App/InfoParser.php:38:50: TaintedFile: Detected tainted file handling (see https://psalm.dev/255)
TaintedCallable: lib/private/AppFramework/Http/Dispatcher.php#L208
lib/private/AppFramework/Http/Dispatcher.php:208:37: TaintedCallable: Detected tainted text (see https://psalm.dev/243)