Merge pull request #42174 from nextcloud/chore/comments-cleanup-dead-…

…code chore(comments): Drop dead code from comments app
nextcloud · Dec 13, 2023 · 11e27ac · 11e27ac
2 parents 6077f26 + 529dcc3
commit 11e27ac
Show file tree

Hide file tree

Showing 14 changed files with 2 additions and 246 deletions.
diff --git a/apps/comments/.bowerrc b/apps/comments/.bowerrc
diff --git a/apps/comments/.l10nignore b/apps/comments/.l10nignore
diff --git a/apps/comments/lib/Listener/LoadAdditionalScripts.php b/apps/comments/lib/Listener/LoadAdditionalScripts.php
@@ -39,9 +39,7 @@ public function handle(Event $event): void {
 			return;
 		}
 
-		// TODO: make sure to only include the sidebar script when
-		// we properly split it between files list and sidebar
-		Util::addScript(Application::APP_ID, 'comments');
+		// Adding init script for file list inline actions
 		Util::addInitScript(Application::APP_ID, 'init');
 	}
 }
diff --git a/apps/comments/lib/Listener/LoadSidebarScripts.php b/apps/comments/lib/Listener/LoadSidebarScripts.php
@@ -51,10 +51,7 @@ public function handle(Event $event): void {
 		$this->commentsManager->load();
 
 		$this->initialState->provideInitialState('activityEnabled', $this->appManager->isEnabledForUser('activity'));
-
-		// TODO: make sure to only include the sidebar script when
-		// we properly split it between files list and sidebar
-		Util::addScript(Application::APP_ID, 'comments');
+		// Add comments sidebar tab script
 		Util::addScript(Application::APP_ID, 'comments-tab', 'files');
 	}
 }
diff --git a/apps/comments/src/activitytabviewplugin.js b/apps/comments/src/activitytabviewplugin.js
diff --git a/apps/comments/src/app.js b/apps/comments/src/app.js
diff --git a/apps/comments/src/comments.js b/apps/comments/src/comments.js
diff --git a/apps/comments/src/templates.js b/apps/comments/src/templates.js
diff --git a/apps/comments/src/templates/filesplugin.handlebars b/apps/comments/src/templates/filesplugin.handlebars
diff --git a/apps/comments/src/utils/numberUtil.js b/apps/comments/src/utils/numberUtil.js
diff --git a/dist/comments-comments.js b/dist/comments-comments.js
diff --git a/dist/comments-comments.js.LICENSE.txt b/dist/comments-comments.js.LICENSE.txt