enh(oauth2): allowed toggling of aria label

Signed-off-by: Eduardo Morales <[email protected]>
nextcloud · Dec 13, 2023 · 2a82c03 · 2a82c03
1 parent b9fe130
commit 2a82c03
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 6 deletions.
diff --git a/apps/oauth2/src/components/OAuthItem.vue b/apps/oauth2/src/components/OAuthItem.vue
@@ -28,11 +28,10 @@
 			<div class="action-secret">
 				<code>{{ renderedSecret }}</code>
 				<NcButton type="tertiary-no-background"
-					:aria-label="t('oauth2', 'Show client secret')"
+					:aria-label="toggleAriaLabel"
 					@click="toggleSecret">
 					<template #icon>
-						<EyeOutline :size="20"
-							:title="t('oauth2', 'Show client secret')" />
+						<EyeOutline :size="20"/>
 					</template>
 				</NcButton>
 			</div>
@@ -87,6 +86,15 @@ export default {
 				return '****'
 			}
 		},
+
+		toggleAriaLabel() {
+			// if the secret key is not rendered (for examples, !this.rendered == '*******'), then suggest to show the secret key
+			if (!this.renderSecret) {
+				return t('oauth2', 'Show client secret')
+			} else {
+				return t('oauth2', 'Hide client secret')
+			}
+		}
 	},
 	methods: {
 		toggleSecret() {