Consider admin defaults when creating shares

The current share logic always uses the default `BUNDLED_PERMISSIONS.ALL` which includes everything. This commit updates share creation logic to use `defaultPermissions` if set by admin for the creation of new shares. Signed-off-by: fenn-cs <[email protected]>
nextcloud · Jan 22, 2024 · 502d6c6 · 502d6c6
1 parent 93db067
commit 502d6c6
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 0 deletions.
diff --git a/apps/files_sharing/lib/Listener/LoadSidebarListener.php b/apps/files_sharing/lib/Listener/LoadSidebarListener.php
@@ -51,6 +51,7 @@ public function handle(Event $event): void {
 
 		$shareConfig = [
 			'allowPublicUploads' => $this->shareManager->shareApiLinkAllowPublicUpload(),
+			'defaultPermissions' => $this->shareManager->shareApiDefaultPermissions()
 		];
 
 		$this->initialState->provideInitialState('shareConfig', $shareConfig);

diff --git a/apps/files_sharing/src/services/ConfigService.js b/apps/files_sharing/src/services/ConfigService.js
@@ -31,6 +31,17 @@ export default class Config {
 		this._shareConfig = loadState('files_sharing', 'shareConfig', {})
 	}
 
+	/**
+	 * Get default share permissions, if any
+	 *
+	 * @return {boolean}
+	 * @readonly
+	 * @memberof Config
+	 */
+	 get defaultPermissions() {
+		return this._shareConfig.defaultPermissions
+	}
+
 	/**
 	 * Is public upload allowed on link shares ?
 	 *

diff --git a/lib/public/Share/IManager.php b/lib/public/Share/IManager.php
@@ -310,6 +310,14 @@ public function newShare();
 	 */
 	public function shareApiEnabled();
 
+	/**
+	 * Get default share permissions set by admin
+	 *
+	 * @return int
+	 * @since 9.0.0
+	 */
+	public function shareApidefaultPermissions(): int;
+
 	/**
 	 * Is public link sharing enabled
 	 *