Apply suggestions from code review in View.php

Co-authored-by: Benjamin Gaussorgues <[email protected]> Signed-off-by: Côme Chilliet <[email protected]> Signed-off-by: Côme Chilliet <[email protected]>
nextcloud · Sep 5, 2023 · 6b2580d · 6b2580d
1 parent 168b07d
commit 6b2580d
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/lib/private/Files/View.php b/lib/private/Files/View.php
@@ -426,11 +426,11 @@ public function readfile($path) {
 		}
 		$handle = $this->fopen($path, 'rb');
 		if ($handle) {
-			$chunkSize = 524288; // 512 kB chunks
+			$chunkSize = 524288; // 512 kiB chunks
 			while (!feof($handle)) {
 				echo fread($handle, $chunkSize);
-				$this->checkConnectionStatus();
 				flush();
+				$this->checkConnectionStatus();
 			}
 			fclose($handle);
 			return $this->filesize($path);
@@ -482,8 +482,8 @@ public function readfilePart($path, $from, $to) {
 						$len = $chunkSize;
 					}
 					echo fread($handle, $len);
-					$this->checkConnectionStatus();
 					flush();
+					$this->checkConnectionStatus();
 				}
 				return ftell($handle) - $from;
 			}
@@ -496,7 +496,7 @@ public function readfilePart($path, $from, $to) {
 
 	private function checkConnectionStatus(): void {
 		$connectionStatus = \connection_status();
-		if ($connectionStatus !== 0) {
+		if ($connectionStatus !== CONNECTION_NORMAL) {
 			throw new ConnectionLostException("Connection lost. Status: $connectionStatus");
 		}
 	}