Skip to content

Commit

Permalink
Merge pull request #41061 from nextcloud/bugfix/noid/dont-use-indirec…
Browse files Browse the repository at this point in the history
…t-dependency

fix(3rdparty): Don't use indirect dependency "Safe/" for functions
  • Loading branch information
nickvergessen authored Oct 24, 2023
2 parents 122e799 + 3a265ce commit 7a55ea7
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@

namespace OCA\DAV\Tests\integration\UserMigration;

use function Safe\scandir;
use function scandir;
use OCA\DAV\AppInfo\Application;
use OCA\DAV\UserMigration\CalendarMigrator;
use OCP\AppFramework\App;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@

namespace OCA\DAV\Tests\integration\UserMigration;

use function Safe\scandir;
use function scandir;
use OCA\DAV\AppInfo\Application;
use OCA\DAV\UserMigration\ContactsMigrator;
use OCP\AppFramework\App;
Expand Down
6 changes: 3 additions & 3 deletions apps/dav/tests/unit/CalDAV/AppCalendar/AppCalendarTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
use PHPUnit\Framework\MockObject\MockObject;
use Test\TestCase;

use function Safe\rewind;
use function rewind;

class AppCalendarTest extends TestCase {
private $principal = 'principals/users/foo';
Expand All @@ -35,7 +35,7 @@ class AppCalendarTest extends TestCase {

private ICalendar|MockObject $calendar;
private ICalendar|MockObject $writeableCalendar;

protected function setUp(): void {
parent::setUp();

Expand Down Expand Up @@ -115,7 +115,7 @@ public function testGetACL():void {
'principal' => $this->principal,
'protected' => true,
];

// Check that the correct ACL is returned (default be only readable)
$this->assertEquals($expectedRO, $this->appCalendar->getACL());
$this->assertEquals($expectedRW, $this->writeableAppCalendar->getACL());
Expand Down
4 changes: 2 additions & 2 deletions core/Db/ProfileConfig.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@

namespace OC\Core\Db;

use function Safe\json_decode;
use function Safe\json_encode;
use function json_decode;
use function json_encode;
use \JsonSerializable;
use OCP\AppFramework\Db\Entity;
use OCP\Profile\ParameterDoesNotExistException;
Expand Down
2 changes: 1 addition & 1 deletion lib/private/Profile/Actions/FediverseAction.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@

namespace OC\Profile\Actions;

use function Safe\substr;
use function substr;
use OCP\Accounts\IAccountManager;
use OCP\IURLGenerator;
use OCP\IUser;
Expand Down
2 changes: 1 addition & 1 deletion lib/private/Profile/Actions/TwitterAction.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@

namespace OC\Profile\Actions;

use function Safe\substr;
use function substr;
use OCP\Accounts\IAccountManager;
use OCP\IURLGenerator;
use OCP\IUser;
Expand Down

0 comments on commit 7a55ea7

Please sign in to comment.