Skip to content

Commit

Permalink
Merge pull request #41063 from nextcloud/fix/37092/dashboard-html-val…
Browse files Browse the repository at this point in the history
…idation
  • Loading branch information
szaimen authored Oct 23, 2023
2 parents fe62fa7 + 4ac06a8 commit 8bd1294
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 10 deletions.
14 changes: 7 additions & 7 deletions apps/dashboard/src/DashboardApp.vue
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
class="panel">
<div class="panel--header">
<h2>
<div :aria-labelledby="`panel-${panels[panelId].id}--header--icon--description`"
<span :aria-labelledby="`panel-${panels[panelId].id}--header--icon--description`"
aria-hidden="true"
:class="apiWidgets[panels[panelId].id].icon_class"
role="img" />
Expand All @@ -39,7 +39,7 @@
<div v-else :key="panels[panelId].id" class="panel">
<div class="panel--header">
<h2>
<div :aria-labelledby="`panel-${panels[panelId].id}--header--icon--description`"
<span :aria-labelledby="`panel-${panels[panelId].id}--header--icon--description`"
aria-hidden="true"
:class="panels[panelId].iconClass"
role="img" />
Expand Down Expand Up @@ -74,7 +74,7 @@
:checked="isStatusActive(status)"
@input="updateStatusCheckbox(status, $event.target.checked)">
<label :for="'status-checkbox-' + status">
<div :class="statusInfo[status].icon" aria-hidden="true" role="img" />
<span :class="statusInfo[status].icon" aria-hidden="true" />
{{ statusInfo[status].text }}
</label>
</li>
Expand All @@ -92,7 +92,7 @@
:checked="isActive(panel)"
@input="updateCheckbox(panel, $event.target.checked)">
<label :for="'panel-checkbox-' + panel.id" :class="{ draggable: isActive(panel) }">
<div :class="panel.iconClass" aria-hidden="true" role="img" />
<span :class="panel.iconClass" aria-hidden="true" />
{{ panel.title }}
</label>
</li>
Expand Down Expand Up @@ -540,7 +540,7 @@ export default {
overflow: hidden;
text-overflow: ellipsis;
cursor: grab;
div {
span {
background-size: 32px;
width: 32px;
height: 32px;
Expand Down Expand Up @@ -633,7 +633,7 @@ export default {
text-overflow: ellipsis;
white-space: nowrap;
div {
span {
position: absolute;
top: 16px;
width: 24px;
Expand All @@ -647,7 +647,7 @@ export default {
}
// Do not invert status icons
&:not(.panel-status) label div {
&:not(.panel-status) label span {
filter: var(--background-invert-if-dark);
}
Expand Down
4 changes: 2 additions & 2 deletions dist/dashboard-main.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/dashboard-main.js.map

Large diffs are not rendered by default.

0 comments on commit 8bd1294

Please sign in to comment.