fix: smb: don't fail hard if we can't load acls for a file

Signed-off-by: Robin Appelman <[email protected]>
nextcloud · Dec 4, 2024 · 8f76edf · 8f76edf
1 parent fc278e1
commit 8f76edf
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/apps/files_external/lib/Lib/Storage/SMB.php b/apps/files_external/lib/Lib/Storage/SMB.php
@@ -235,7 +235,12 @@ protected function throwUnavailable(\Exception $e) {
 	 * @return ACL|null
 	 */
 	private function getACL(IFileInfo $file): ?ACL {
-		$acls = $file->getAcls();
+		try {
+			$acls = $file->getAcls();
+		} catch (Exception $e) {
+			$this->logger->error('Error while getting file acls', ['exception' => $e]);
+			return null;
+		}
 		foreach ($acls as $user => $acl) {
 			[, $user] = $this->splitUser($user); // strip domain
 			if ($user === $this->server->getAuth()->getUsername()) {