Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump doctrine/dbal to 3.5.1 in master #35084

Closed
wants to merge 1 commit into from
Closed

Bump doctrine/dbal to 3.5.1 in master #35084

wants to merge 1 commit into from

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Nov 10, 2022 •
edited
Loading

@come-nc come-nc self-assigned this Nov 10, 2022
@come-nc come-nc added this to the Nextcloud 26 milestone Nov 10, 2022
szaimen
szaimen approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@nickvergessen
Copy link
Member

Error: lib/private/DB/Connection.php:127:12: InternalMethod: The method Doctrine\DBAL\Connection::connect is internal to Doctrine but called from OC\DB\Connection

🪦

@nickvergessen nickvergessen mentioned this pull request Nov 11, 2022
Merged
@come-nc
Copy link
Contributor Author

come-nc commented Nov 14, 2022

lib/private/DB/Connection.php:127:12

@nickvergessen Do we have any other choice than to ignore those errors?
From what I understand real changes will only happen with dbal 4.x.

Should I add those Internal* errors to the baseline?

(Note that there is also a test error that needs to be looked into)

@come-nc
Copy link
Contributor Author

come-nc commented Nov 14, 2022 •
edited
Loading

ref: https://github.com/doctrine/dbal/blob/3.5.x/UPGRADE.md

A lot of things got deprecated or marked as internal

This was referenced Nov 15, 2022
Closed
Merged
@come-nc come-nc closed this Nov 21, 2022
@skjnldsv skjnldsv deleted the fix/bump-doctrine/dbal-to-3.5.1-in-master branch March 14, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

Assignees

@come-nc come-nc

Labels
None yet
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
3 participants
@come-nc @nickvergessen @szaimen