chore(deps): Bump doctrine/dbal to 3.7.x #38556

nickvergessen · 2023-05-31T14:27:38Z

TODO

chore(deps): Bump doctrine/dbal to 3.7.x 3rdparty#1424

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Screenshots before/after for front-end changes
Documentation (manuals or wiki) has been updated or is not required feat(developer): Document doctrine/dbal update to 3.7.x documentation#10712
Backports requested where applicable (ex: critical bugfixes)

apps/files_sharing/tests/Command/CleanupRemoteStoragesTest.php

nickvergessen · 2023-07-05T07:40:11Z

Forgot the schema migration thingy. Back to draft.

nickvergessen · 2023-07-05T08:20:44Z

OC\Repair\SqliteAutoincrement
- I installed current master and exported the schema as SQL
- Then I went to this branch, removed the content of the run() method (so made it no-op)
- I installed again and exported the schema as SQL
- The files are exactly the same, so whatever we tried to fix was fixed since 2015 in doctrine dbal :-O
  -> Removed

lib/private/DB/Migrator.php

lib/private/DB/OracleMigrator.php

lib/private/DB/Migrator.php

lib/private/DB/OracleMigrator.php

lib/private/DB/Migrator.php

blizzz · 2023-10-06T11:49:53Z

lib/private/DB/Migrator.php

@@ -178,7 +178,7 @@ protected function convertStatementToScript($statement) {
 	}

 	protected function getFilterExpression() {
-		return '/^' . preg_quote($this->config->getSystemValueString('dbtableprefix', 'oc_')) . '/';
+		return '/^' . preg_quote($this->config->getSystemValueString('dbtableprefix', 'oc_'), '/') . '/';


Signed-off-by: Joas Schilling <[email protected]>

…on Doctrine/DBAL Signed-off-by: Joas Schilling <[email protected]>

- I installed current master and exported the schema as SQL - Then I went to this branch, removed the content of the run() method (so made it no-op) - I installed again and exported the schema as SQL - The files are exactly the same, so whatever we tried to fix was fixed since 2015 in doctrine dbal Signed-off-by: Joas Schilling <[email protected]>

Postgres 10 is the minimum in the meantime and doctrine/dbal fixed this in 2.6.0 already ref doctrine/dbal#2614 Signed-off-by: Joas Schilling <[email protected]>

Signed-off-by: Joas Schilling <[email protected]>

- Doctrine correctly forces integer for autoincrement by now - Doctrine correctly maintains integer types by now Signed-off-by: Joas Schilling <[email protected]>

Signed-off-by: Joas Schilling <[email protected]>

nickvergessen added the 2. developing Work in progress label May 31, 2023

nickvergessen added this to the Nextcloud 28 milestone May 31, 2023

nickvergessen self-assigned this May 31, 2023

nickvergessen marked this pull request as draft May 31, 2023 14:27

nickvergessen mentioned this pull request May 31, 2023

test: CI against doctrine/dbal 3.6.2 nextcloud/spreed#9664

Closed

6 tasks

nickvergessen commented Jun 1, 2023

View reviewed changes

apps/files_sharing/tests/Command/CleanupRemoteStoragesTest.php Outdated Show resolved Hide resolved

nickvergessen added pending documentation This pull request needs an associated documentation update enhancement labels Jun 1, 2023

nickvergessen mentioned this pull request Jul 5, 2023

chore(deps): Bump doctrine/dbal to 3.7.x nextcloud/3rdparty#1424

Merged

nickvergessen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 5, 2023

nickvergessen force-pushed the techdebt/noid/doctrine/dbal-to-3.6.2 branch from ac82534 to 85ce06c Compare July 5, 2023 07:08

nickvergessen requested review from ChristophWurst, blizzz and come-nc July 5, 2023 07:09

nickvergessen marked this pull request as ready for review July 5, 2023 07:09

nickvergessen mentioned this pull request Jul 5, 2023

feat(developer): Document doctrine/dbal update to 3.7.x nextcloud/documentation#10712

Merged

nickvergessen marked this pull request as draft July 5, 2023 07:40

github-advanced-security bot found potential problems Jul 5, 2023

View reviewed changes

lib/private/DB/Migrator.php Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems Jul 5, 2023

View reviewed changes

lib/private/DB/OracleMigrator.php Fixed Show fixed Hide fixed

nickvergessen force-pushed the techdebt/noid/doctrine/dbal-to-3.6.2 branch from b7a05ef to 56aec0b Compare July 6, 2023 08:32

This comment was marked as resolved.

Sign in to view

This was referenced Aug 17, 2023

Add MariaDB 10.11 (LTS) and PHP 8.2 to drone pipeline #38161

Closed

fix(tests): Specify all positional parameters again to fix tests #40012

Merged

nickvergessen changed the title ~~chore(deps): Bump doctrine/dbal to supported 3.6.2~~ chore(deps): Bump doctrine/dbal to 3.7.x Sep 29, 2023

nickvergessen force-pushed the techdebt/noid/doctrine/dbal-to-3.6.2 branch 2 times, most recently from aa9f1f7 to f2ef8e7 Compare September 29, 2023 12:47

github-advanced-security bot found potential problems Sep 29, 2023

View reviewed changes

nickvergessen force-pushed the techdebt/noid/doctrine/dbal-to-3.6.2 branch from f2ef8e7 to 87e3d81 Compare September 29, 2023 13:07

github-advanced-security bot found potential problems Sep 29, 2023

View reviewed changes

lib/private/DB/OracleMigrator.php Fixed Show fixed Hide fixed

lib/private/DB/OracleMigrator.php Fixed Show fixed Hide fixed

nickvergessen force-pushed the techdebt/noid/doctrine/dbal-to-3.6.2 branch 3 times, most recently from 2eb7267 to b59e769 Compare September 29, 2023 15:44

nickvergessen marked this pull request as ready for review September 29, 2023 18:16

nickvergessen requested review from Altahrim and kesselb September 29, 2023 18:16

AndyScherzinger requested a review from sorbaugh September 30, 2023 19:31

come-nc reviewed Oct 2, 2023

View reviewed changes

lib/private/DB/Migrator.php Show resolved Hide resolved

lib/private/DB/Migrator.php Outdated Show resolved Hide resolved

lib/private/DB/OracleMigrator.php Show resolved Hide resolved

Altahrim approved these changes Oct 2, 2023

View reviewed changes

lib/private/DB/Migrator.php Show resolved Hide resolved

nickvergessen requested a review from come-nc October 4, 2023 08:30

blizzz approved these changes Oct 6, 2023

View reviewed changes

nickvergessen added 10 commits October 6, 2023 15:29

chore(deps): Bump doctrine/dbal to supported 3.7.0

18d672c

Signed-off-by: Joas Schilling <[email protected]>

fix(dbal): Doctrine\DBAL\Connection::PARAM_* types are deprecated

c4ed7f9

Signed-off-by: Joas Schilling <[email protected]>

feat(CI): Add a stub for SensitiveParameter, so Psalm is not failing …

00acf1b

…on Doctrine/DBAL Signed-off-by: Joas Schilling <[email protected]>

fix(postgres): Remove old Postgres 9.4 workaround

b202b13

Postgres 10 is the minimum in the meantime and doctrine/dbal fixed this in 2.6.0 already ref doctrine/dbal#2614 Signed-off-by: Joas Schilling <[email protected]>

fix(mysql): Remove custom MySQL workaround from 2015

160298c

Signed-off-by: Joas Schilling <[email protected]>

fix(dbal): Move migrator away from deprecated calls

9192078

Signed-off-by: Joas Schilling <[email protected]>

fix(oracle): Move away from internal and deprecated SchemaDiff API

f8ee6c4

Signed-off-by: Joas Schilling <[email protected]>

fix(sqlite): Remove some old SQLite cheats

ccb01b1

- Doctrine correctly forces integer for autoincrement by now - Doctrine correctly maintains integer types by now Signed-off-by: Joas Schilling <[email protected]>

fix(DB): Update comment to state why we still use the max 4k limit

570159e

Signed-off-by: Joas Schilling <[email protected]>

nickvergessen force-pushed the techdebt/noid/doctrine/dbal-to-3.6.2 branch from cf8e0bc to 570159e Compare October 6, 2023 13:29

nickvergessen merged commit 71cd97c into master Oct 6, 2023
40 checks passed

nickvergessen deleted the techdebt/noid/doctrine/dbal-to-3.6.2 branch October 6, 2023 14:21

nickvergessen removed the pending documentation This pull request needs an associated documentation update label Jul 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(deps): Bump doctrine/dbal to 3.7.x #38556

chore(deps): Bump doctrine/dbal to 3.7.x #38556

nickvergessen commented May 31, 2023 •

edited

Loading

nickvergessen commented Jul 5, 2023

nickvergessen commented Jul 5, 2023

This comment was marked as resolved.

blizzz Oct 6, 2023

chore(deps): Bump doctrine/dbal to 3.7.x #38556

chore(deps): Bump doctrine/dbal to 3.7.x #38556

Conversation

nickvergessen commented May 31, 2023 • edited Loading

TODO

Checklist

nickvergessen commented Jul 5, 2023

nickvergessen commented Jul 5, 2023

This comment was marked as resolved.

blizzz Oct 6, 2023

Choose a reason for hiding this comment

nickvergessen commented May 31, 2023 •

edited

Loading