Refactors files_external app commands #39131
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| private function createStorage(StorageConfig $mount): IStorage { | ||
| $class = $mount->getBackend()->getStorageClass(); | ||
| return new $class($mount->getBackendOptions()); | ||
| } | ||
|
|
||
| private function markParentAsOutdated($mountId, $path, OutputInterface $output, bool $dryRun) { | ||
| private function markParentAsOutdated($mountId, $path, OutputInterface $output, bool $dryRun): void { |
Check notice
Code scanning / Psalm
MissingParamType Note
| } | ||
|
|
||
| private function createStorage(StorageConfig $mount): IStorage { | ||
| $class = $mount->getBackend()->getStorageClass(); | ||
| return new $class($mount->getBackendOptions()); | ||
| } | ||
|
|
||
| private function markParentAsOutdated($mountId, $path, OutputInterface $output, bool $dryRun) { | ||
| private function markParentAsOutdated($mountId, $path, OutputInterface $output, bool $dryRun): void { |
Check notice
Code scanning / Psalm
MissingParamType Note
| $backend = $storage->getBackend(); | ||
| $backend->manipulateStorageConfig($storage); | ||
| } | ||
|
|
||
| private function updateStorageStatus(StorageConfig &$storage, $configInput, OutputInterface $output) { | ||
| private function updateStorageStatus(StorageConfig &$storage, $configInput, OutputInterface $output): void { |
Check notice
Code scanning / Psalm
MissingParamType Note
|
CI and Psalm failing 🔴 |
Psalm's not failing. Is it? Other failing actions do not seem to be related to the changes that I have made and none of them are labeled as "Required". |
szaimen
requested review from
skjnldsv,
CarlSchwan,
come-nc,
a team and
ArtificialOwl
and removed request for
a team
fsamapoor
force-pushed
the
refactor_lib_files_external_commands
branch
from
437d0b1 to
86822ee
Compare
To improve code readability. Signed-off-by: Faraz Samapoor <[email protected]> Signed-off-by: Faraz Samapoor <[email protected]>
Co-authored-by: Côme Chilliet <[email protected]> Signed-off-by: Faraz Samapoor <[email protected]> Signed-off-by: Faraz Samapoor <[email protected]>
fsamapoor
force-pushed
the
refactor_lib_files_external_commands
branch
from
86822ee to
eab7818
Compare
|
CI failure unrelated |
Summary
I have made some adjustments to the
apps/files_external/lib/Commandclasses to improve code readability.The improvements in this PR include but are not limited to:
Checklist