Convert isset ternary to null coalescing operator #39224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
requested review from
a team,
ArtificialOwl,
icewind1991 and
nfebe
and removed request for
a team
juliusknorr
approved these changes
Jul 10, 2023
fsamapoor
force-pushed
the
null_coalescing_conversion_lib_private
branch
from
3f7ae91 to
6c91a2a
Compare
nfebe
approved these changes
Sep 28, 2023
|
@shdehnavi please fix conflicts and rebase. Thank you! |
Signed-off-by: Hamid Dehnavi <[email protected]>
shdehnavi
force-pushed
the
null_coalescing_conversion_lib_private
branch
from
6c91a2a to
ea06cf2
Compare
Resolved and Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims to enhance code readability and simplify ternary operations in the codebase. It replaces all instances of
issetternary operations with the more concise and expressive null coalescing operator in/lib/privatenamespace. The conversion eliminates unnecessary redundancy and improves maintainability.Checklist