Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor lib/private/App #39299

Merged
merged 4 commits into from
Feb 23, 2024
Merged

Refactor lib/private/App #39299

merged 4 commits into from
Feb 23, 2024

Conversation

shdehnavi
Copy link
Contributor

Summary

The required adjustments have been made to the following classes in the /lib/private/app namespace.

The improvements:

  • Using PHP8's constructor property promotion

Checklist

@solracsf solracsf added 3. to review Waiting for reviews technical debt labels Jul 11, 2023
@solracsf solracsf added this to the Nextcloud 28 milestone Jul 11, 2023
@shdehnavi
Copy link
Contributor Author

Hey @szaimen
The following PRs haven't been assigned to any reviewers yet.
Could you please be so kind and assign them to reviewers? bc I want to make the new PRs and still I have 30 open PRs.
#39249
#39246
#39245
#39244
#39243
#39236
#39235
#39226
#39217
#39216
#39215
#39213
#39212
#39211
#39209
#39208
#39183
#39182
#39177
#39176
#39175
#39174
#39173
#39163

@szaimen
Copy link
Contributor

szaimen commented Jul 13, 2023 •
edited
Loading

Hi @shdehnavi thanks a lot for the many PRs! Can you check if you can request the review itself? Usually you should be able to request reviews from the nextcloud/server-backend group. Does that work for you?

@shdehnavi
Copy link
Contributor Author

Hi @shdehnavi thanks a lot for the many PRs! Can you check if you can request the review itself? Usually you should be able to request reviews from the nextcloud/server-backend group. Does that work for you?

sure, i will do it

@shdehnavi shdehnavi requested review from tcitworld and come-nc July 14, 2023 12:14
@fsamapoor
Copy link
Member

Could you please resolve the conflicts?

@shdehnavi shdehnavi force-pushed the refactor_lib_private_app branch from 15b7c09 to 901f15a Compare August 16, 2023 06:35
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 16, 2023
View reviewed changes
lib/private/App/AppManager.php Fixed Show resolved Hide resolved
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
Merged
This was referenced Nov 6, 2023
Merged
Merged
This was referenced Nov 14, 2023
Merged
Merged
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@shdehnavi shdehnavi force-pushed the refactor_lib_private_app branch from 901f15a to 0eeea83 Compare December 11, 2023 13:03
@shdehnavi
Copy link
Contributor Author

@blizzz All conflicts have been resolved, Ready to merge.

shdehnavi and others added 4 commits February 23, 2024 15:53
@shdehnavi @skjnldsv
Refactor lib/private/App
84749d5 
Signed-off-by: Hamid Dehnavi <[email protected]>
@shdehnavi @skjnldsv
Fix code style
7a8d79b 
Signed-off-by: Hamid Dehnavi <[email protected]>
@shdehnavi @juliusknorr @skjnldsv
Make adjustments based on the psalm review
b6ef67e 
Signed-off-by: Hamid Dehnavi <[email protected]>
Co-authored-by: Julius Härtl <[email protected]>
Signed-off-by: Hamid Dehnavi <[email protected]>
@shdehnavi @skjnldsv
Fix psalm errors
cf17db2 
Signed-off-by: Hamid Dehnavi <[email protected]>
@skjnldsv skjnldsv force-pushed the refactor_lib_private_app branch from c3cb6fc to cf17db2 Compare February 23, 2024 14:53
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 23, 2024
@skjnldsv skjnldsv enabled auto-merge February 23, 2024 14:54
@skjnldsv skjnldsv disabled auto-merge February 23, 2024 18:24
@skjnldsv skjnldsv merged commit c4975b3 into nextcloud:master Feb 23, 2024
149 of 158 checks passed
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@fsamapoor fsamapoor fsamapoor approved these changes

@tcitworld tcitworld Awaiting requested review from tcitworld

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish technical debt
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.
7 participants
@shdehnavi @szaimen @fsamapoor @come-nc @blizzz @solracsf @skjnldsv