-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Saved ticket support for kerberos #40165
Draft
icewind1991
wants to merge
5
commits into
master
Choose a base branch
from
kerberos-saved-ticket
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
force-pushed
the
kerberos-saved-ticket
branch
from
September 1, 2023 15:02
815e821
to
7aed00a
Compare
use OCP\IL10N; | ||
use OCP\ISession; | ||
|
||
class KerberosSsoSession extends AuthMechanism { |
Check notice
Code scanning / Psalm
PropertyNotSetInConstructor Note
Property OCA\Files_External\Lib\Auth\SMB\KerberosSsoSession::$scheme is not defined in constructor of OCA\Files_External\Lib\Auth\SMB\KerberosSsoSession or in any private or final methods called in the constructor
icewind1991
force-pushed
the
kerberos-saved-ticket
branch
from
September 5, 2023 12:30
85ff7e6
to
068a0d1
Compare
icewind1991
force-pushed
the
kerberos-saved-ticket
branch
from
September 6, 2023 13:42
068a0d1
to
ff18f8b
Compare
use OCP\IUser; | ||
use OCP\Security\ICredentialsManager; | ||
|
||
class KerberosSsoDatabase extends AuthMechanism { |
Check notice
Code scanning / Psalm
PropertyNotSetInConstructor Note
Property OCA\Files_External\Lib\Auth\SMB\KerberosSsoDatabase::$scheme is not defined in constructor of OCA\Files_External\Lib\Auth\SMB\KerberosSsoDatabase or in any private or final methods called in the constructor
icewind1991
force-pushed
the
kerberos-saved-ticket
branch
from
September 21, 2023 14:29
ff18f8b
to
1491368
Compare
icewind1991
force-pushed
the
kerberos-saved-ticket
branch
2 times, most recently
from
October 20, 2023 07:42
45ab2b9
to
13db180
Compare
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
kerberos-saved-ticket
branch
from
October 24, 2023 14:13
102aa2b
to
70c9f5f
Compare
This was referenced Mar 12, 2024
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows saving kerberos ticket in session for reuse