Add "MFA Verified" check to workflowengine #40235
Conversation
Signed-off-by: MohammadReza vahedi <[email protected]>
Signed-off-by: Michiel de Jong <[email protected]>
michielbdejong
force-pushed
the
mrv/mfa-check-rebased
branch
from
ee9c992 to
02604be
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
apps/workflowengine/lib/Manager.php
Outdated
| @@ -759,6 +767,7 @@ | |||
| $this->container->query(FileName::class), | |||
| $this->container->query(FileSize::class), | |||
| $this->container->query(FileSystemTags::class), | |||
| $this->container->query(MfaVerified::class), | |||
Check notice
Code scanning / Psalm
DeprecatedMethod Note
Signed-off-by: MohammadReza vahedi <[email protected]>
|
Can this be merged if it looks good? |
|
@come-nc what is the next step in the process now? |
come-nc
requested review from
a team,
ArtificialOwl,
icewind1991 and
nfebe
and removed request for
a team
|
@ArtificialOwl can you maybe have a look? |
|
I'm worried about the lack of communication here, @mickenordin can you ask your NC support contact for advice? |
|
@skjnldsv Thanks for mentioning this PR for NC 28! Will you be the person merging it? Anything we can do to help you? Note that the conflicting files in the dist folders are easy to leave out and then rebuild after you merge! |
|
@michielbdejong you're missing two reviews. Pinging maintainers nonetheless: @blizzz and @juliushaertl |
|
With beta from last week, we're behind feature freeze for 28 😧 |
| * @copyright Copyright (c) 2016 Joas Schilling <[email protected]> | ||
| * | ||
| * @author Arthur Schiwon <[email protected]> | ||
| * @author Christoph Wurst <[email protected]> | ||
| * @author Joas Schilling <[email protected]> | ||
| * @author Julius Härtl <[email protected]> | ||
| * @author Richard Steinmetz <[email protected]> |
Signed-off-by: Michiel de Jong <[email protected]>
Co-authored-by: Arthur Schiwon <[email protected]> Signed-off-by: Michiel de Jong <[email protected]>
|
I succeeded in adding this check inside https://github.com/pondersource/mfazones instead of adding it to nextcloud/server, so we can close this PR. If anyone wants to use the |
Rebase of #39471