Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make logo in header clickable in the shared file view #40439

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

Koc
Copy link
Contributor

@Koc Koc commented Sep 15, 2023

Summary

Now we use same logo_url settings for shared file view that are used for normal user view.

image

Open questions

  • How to deal if logo_url is not configured? Use home link (like now) or make logo non-clickable?

How to test

  1. update config/config.php with
      'logo_url' => 'https://google.com',
  2. share file by creating public link
  3. open shared link
  4. click on logo

Checklist

@Koc Koc force-pushed the feature/clickable-logo branch from a53c1a8 to 71c7e18 Compare September 15, 2023 15:17
@AndyScherzinger AndyScherzinger added 3. to review Waiting for reviews papercut Annoying recurring issue with possibly simple fix. labels Sep 15, 2023
@AndyScherzinger AndyScherzinger added this to the Nextcloud 28 milestone Sep 15, 2023
core/templates/layout.public.php Outdated Show resolved Hide resolved
@Koc Koc force-pushed the feature/clickable-logo branch from 6af2f05 to 4137035 Compare October 3, 2023 21:36
@Koc Koc requested a review from skjnldsv October 3, 2023 21:36
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 4, 2023
@skjnldsv skjnldsv merged commit 4756807 into nextcloud:master Oct 4, 2023
36 of 40 checks passed
@welcome
Copy link

welcome bot commented Oct 4, 2023

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish feature: sharing papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants