-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(isLegitimatedForUserId): Setup mountpoints to check file access #40482
Conversation
@icewind1991 do you think this can be a performance killer? |
fe3d6f4
to
76a156d
Compare
76a156d
to
a4d98c8
Compare
It isn't worse than the previous code ( |
a4d98c8
to
9df4da5
Compare
dac55c5
to
a07df9a
Compare
Cypress test failures seem unrelated. PR should be ready for review 😊 |
By the way, I manually tested the following scenarios (all with a
|
28fdcb9
to
5858970
Compare
74b0139
to
576eba9
Compare
a72a31d
to
ec31c90
Compare
ec31c90
to
c7d209d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One psalm complaint, but otherwise seems reasonable 👍
This fixes workflows on groupfolders, as it will consider access to files in groupfolders. It also fixes false positives where access to files was limited by other means not taken into account before, e.g. access control. For postDelete events, check for permissions of the parent folder instead, as the file itself no longer exists. Fixes: nextcloud/flow_notifications#71 Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
c7d209d
to
7441ce2
Compare
Thanks @juliushaertl. I addressed the psalm complaint now. |
Will need manual backports without the public interface changes to stable27 and stable26. |
/backport to stable27 |
1 similar comment
/backport to stable27 |
This fixes workflows on groupfolders, as it will consider access to files in groupfolders.
It also fixes false positives where access to files was limited by other means not taken into account before, e.g. access control.
For postDelete events, check for permissions of the parent folder instead, as the file itself no longer exists.
Fixes: nextcloud/flow_notifications#71
Idea taken from #38946
Checklist