fix(sharing): set name to target name in sharing cache #40495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No idea how to best test this. |
|
/backport to stable27 |
|
/backport to stable26 |
|
/backport to stable25 |
blizzz
approved these changes
Sep 19, 2023
|
Failing tests are related And that should answer your:
|
miaulalala
approved these changes
Oct 4, 2023
Fixes #39879. Signed-off-by: Max <[email protected]>
…get name Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
fix/master-name-in-share-cache
branch
from
66d5697 to
f3ae617
Compare
|
Tests fixed and covered logic with a new one with @max-nextcloud Cypress failure is unrelated |
This was referenced Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39879.
Recent pages now also show the name the file has for the recipient.
After the files2vue rework we are using a different endpoint for recent pages which also fixes the user facing bug. However I think the underlying bug remains.
Checklist