Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable25] add wrapper for external storage to ensure we don't get an mtime that is lower than we know it is #40571

Closed
wants to merge 3 commits into from

Conversation

backportbot-nextcloud[bot]
Copy link

Backport of #40499

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Psalm found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@@ -40,29 +41,17 @@
use OCP\Files\Storage\IStorageFactory;
use OCP\Files\StorageNotAvailableException;
use OCP\IUser;
use Psr\Clock\ClockInterface;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a dependency on 25

@blizzz blizzz mentioned this pull request Oct 9, 2023
1 task
@blizzz blizzz added the 2. developing Work in progress label Oct 9, 2023
@blizzz blizzz removed this from the Nextcloud 25.0.13 milestone Oct 12, 2023
@icewind1991 icewind1991 force-pushed the backport/40499/stable25 branch from 180f6d3 to a3af20f Compare October 24, 2023 15:09
@icewind1991 icewind1991 force-pushed the backport/40499/stable25 branch from a3af20f to 99e84de Compare October 25, 2023 13:17
return $result;
}

public function rename($source, $target) {

Check failure

Code scanning / Psalm

ParamNameMismatch Error

Argument 1 of OC\Files\Storage\Wrapper\KnownMtime::rename has wrong name $source, expecting $path1 as defined by OCP\Files\Storage\IStorage::rename
return $result;
}

public function rename($source, $target) {

Check failure

Code scanning / Psalm

ParamNameMismatch Error

Argument 2 of OC\Files\Storage\Wrapper\KnownMtime::rename has wrong name $target, expecting $path2 as defined by OCP\Files\Storage\IStorage::rename
return $result;
}

public function copy($source, $target) {

Check failure

Code scanning / Psalm

ParamNameMismatch Error

Argument 1 of OC\Files\Storage\Wrapper\KnownMtime::copy has wrong name $source, expecting $path1 as defined by OCP\Files\Storage\IStorage::copy
return $result;
}

public function copy($source, $target) {

Check failure

Code scanning / Psalm

ParamNameMismatch Error

Argument 2 of OC\Files\Storage\Wrapper\KnownMtime::copy has wrong name $target, expecting $path2 as defined by OCP\Files\Storage\IStorage::copy
@blizzz
Copy link
Member

blizzz commented Dec 14, 2023

:tumbleweed:

@blizzz
Copy link
Member

blizzz commented Jan 24, 2024

closing for lack of activity

@blizzz blizzz closed this Jan 24, 2024
@skjnldsv skjnldsv deleted the backport/40499/stable25 branch March 14, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants