Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable27] fix: encode uri for trashbin delete #40642

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Sep 26, 2023

Summary

Similar to #40045 but different ;)

# is a valid character for our filenames but also for uris in general and therefore not encoded by default.
To use # in filenames we need to encode it.

TODO

  • CI
  • Review

Checklist

@kesselb kesselb added bug 3. to review Waiting for reviews labels Sep 26, 2023
@kesselb kesselb added this to the Nextcloud 27.1.2 milestone Sep 26, 2023
@kesselb kesselb self-assigned this Sep 26, 2023
Signed-off-by: Daniel Kesselberg <[email protected]>
@kesselb kesselb force-pushed the fix/noid/stable27-encode-uri-trashbin-restore branch from a0463cf to d280912 Compare September 26, 2023 14:47
@blizzz blizzz mentioned this pull request Sep 26, 2023
@kesselb kesselb added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 27, 2023
@kesselb kesselb merged commit 4393db3 into stable27 Sep 28, 2023
@kesselb kesselb deleted the fix/noid/stable27-encode-uri-trashbin-restore branch September 28, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants