Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add out-of-office message API #40653

Merged
merged 1 commit into from
Nov 9, 2023
Merged

feat: Add out-of-office message API #40653

merged 1 commit into from
Nov 9, 2023

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Sep 27, 2023

Summary

tbd

TODO

  • Emit events
  • Coordinator implementation
  • OCS endpoint(s)
  • Caching layer

Checklist

@blizzz blizzz mentioned this pull request Nov 6, 2023
@st3iny st3iny added the pending documentation This pull request needs an associated documentation update label Nov 7, 2023
@ChristophWurst
Copy link
Member Author

ChristophWurst commented Nov 8, 2023

  • We will also need an OutOfOfficeClearedEvent next to OutOfOfficeScheduledEvent and OutOfOfficeChangedEvent.

@ChristophWurst
Copy link
Member Author

Events are emitted. Anything else missing?

@ChristophWurst
Copy link
Member Author

The events part is definitely done and working. Tested with #41340 :)

@ChristophWurst
Copy link
Member Author

Let's get this in

@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 8, 2023
@ChristophWurst ChristophWurst marked this pull request as ready for review November 8, 2023 15:41
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenAPI looks good

Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, but now it works. There was a casing issue in ResponseDefinitions.

Thanks for taking care of the cleared event.

Unfortunately, OutOfOfficeStartedEvent and OutOfOfficeEndedEvent are not emitted yet. I have a very crude version locally that has some problems.

I can push it if required. IIRC, we might need it for the autoresponder in Mail.

@ChristophWurst
Copy link
Member Author

Right. I only looked at the CRUD events, not the time related once.

We can also split the PR into the bits that already work and deliver the rest later

[skipci]

Signed-off-by: Christoph Wurst <[email protected]>
Signed-off-by: Richard Steinmetz <[email protected]>
@st3iny
Copy link
Member

st3iny commented Nov 9, 2023

Unfinished events are gone and we are good now.

Copy link
Member Author

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for the latest pushes

@ChristophWurst ChristophWurst merged commit 5183ba2 into master Nov 9, 2023
46 of 50 checks passed
@ChristophWurst ChristophWurst deleted the feat/ooo-api branch November 9, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews feature: users and groups integration pending documentation This pull request needs an associated documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Out-of-office: Expose data via OCP/OCS APIs
4 participants