-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add out-of-office message API #40653
Conversation
|
Events are emitted. Anything else missing? |
The events part is definitely done and working. Tested with #41340 :) |
Let's get this in |
7741144
to
033db53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OpenAPI looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, but now it works. There was a casing issue in ResponseDefinitions
.
Thanks for taking care of the cleared event.
Unfortunately, OutOfOfficeStartedEvent
and OutOfOfficeEndedEvent
are not emitted yet. I have a very crude version locally that has some problems.
I can push it if required. IIRC, we might need it for the autoresponder in Mail.
Right. I only looked at the CRUD events, not the time related once. We can also split the PR into the bits that already work and deliver the rest later |
[skipci] Signed-off-by: Christoph Wurst <[email protected]> Signed-off-by: Richard Steinmetz <[email protected]>
Unfinished events are gone and we are good now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 for the latest pushes
Summary
tbd
TODO
Checklist