fix(theming): Stop leaking user theme into capabilities #40877
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
approved these changes
Oct 12, 2023
|
Might need some alignment between @nextcloud/designers and @tobiasKaminsky as those capabilities are used to style the clients. I would still expect the user colors in there |
|
I agree that the user theming should be exposed in the capabilities. I intend to implement that, but currently the capabilities expose a mix of user and admin theming. |
szaimen
approved these changes
Oct 12, 2023
juliusknorr
approved these changes
Oct 12, 2023
|
Right now I see no change for clients. |
|
@provokateurin Drone errors are related. |
|
Yes I know, I just didn't have the time yet :) |
provokateurin
force-pushed
the
fix/theming/capabilities-user-theme-leak
branch
from
a11a4f7 to
8a844c8
Compare
Signed-off-by: jld3103 <[email protected]>
provokateurin
force-pushed
the
fix/theming/capabilities-user-theme-leak
branch
from
8a844c8 to
837eb45
Compare
|
I think the drone failure now is unrelated. Can someone confirm and possibly give it a force merge? |
4 tasks
|
Closed in favor of #41059 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The capabilities were mixing the admin theme and the user theme. For now I set to only use the admin theming, but I intend to submit a second fix that uses the user theme if a the request came from a logged in user.
Checklist