Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce left margin of files list header #40905

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Reduce left margin of files list header #40905

merged 1 commit into from
Oct 17, 2023

Conversation

JuliaKirschenheuter
Copy link
Contributor

Summary

🏚️ Before 🏡 After
image Screenshot from 2023-10-13 15-57-49

Checklist

@JuliaKirschenheuter JuliaKirschenheuter added the 3. to review Waiting for reviews label Oct 13, 2023
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Oct 13, 2023
@JuliaKirschenheuter JuliaKirschenheuter mentioned this pull request Oct 13, 2023
Closed
skjnldsv
skjnldsv requested changes Oct 13, 2023
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment •
edited by JuliaKirschenheuter
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I had to dig into this so we can move forward

  • 1: Fix the min-width on the nav in the vue components (like mentioned here)
  • 2: Add a max-width: 100%; on the .files-list__header

Then it will be fixed.
Peek 13-10-2023 16-47

@skjnldsv

This comment was marked as resolved.

Sign in to view
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 17, 2023
@skjnldsv skjnldsv force-pushed the fix/36965-apadt-margin-for-files_list_header branch from deee9c6 to fe91982 Compare October 17, 2023 19:33
@skjnldsv skjnldsv force-pushed the fix/36965-apadt-margin-for-files_list_header branch from fe91982 to ce7f774 Compare October 17, 2023 19:38
@skjnldsv skjnldsv force-pushed the fix/36965-apadt-margin-for-files_list_header branch from ce7f774 to 0c1b924 Compare October 17, 2023 19:41
@JuliaKirschenheuter @skjnldsv
Reduce left margin of files list header
0d53f54 
Signed-off-by: julia.kirschenheuter <[email protected]>
@skjnldsv skjnldsv force-pushed the fix/36965-apadt-margin-for-files_list_header branch from 0c1b924 to 0d53f54 Compare October 17, 2023 19:43
@Pytal Pytal merged commit ff76e25 into master Oct 17, 2023
37 of 40 checks passed
@Pytal Pytal deleted the fix/36965-apadt-margin-for-files_list_header branch October 17, 2023 22:02
@AndyScherzinger AndyScherzinger added this to the Nextcloud 28 milestone Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen left review comments

@Pytal Pytal Pytal approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@susnux susnux Awaiting requested review from susnux

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility bug
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
5 participants
@JuliaKirschenheuter @skjnldsv @AndyScherzinger @Pytal @szaimen