-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blurhash generation #41044
Blurhash generation #41044
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Psalm found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
15cdbe8
to
c89df97
Compare
7ab7aaa
to
1cbbe62
Compare
1cbbe62
to
915577d
Compare
1b13b8e
to
683ef89
Compare
9ab9645
to
76faa13
Compare
1065e8a
to
2fc9ba3
Compare
7205ff1
to
f497d8b
Compare
26f0d4d
to
15688f6
Compare
0ca5f48
to
52edf28
Compare
Signed-off-by: Maxence Lange <[email protected]>
52edf28
to
4367a5e
Compare
Is it expected that running Without blurhash:
With blurhash:
|
Yes,
|
3 times with blurhash:
and three times without:
Basically only the default media files from julius docker dev (see https://github.com/juliushaertl/nextcloud-docker-dev/tree/master/data/skeleton):
|
Catching FilesMetadata's event and when encountering an image file, this will fill metadata with blurhash [1] which is a little string that simulate a placeholder.
Should greatly improve loading smoothness when displaying gallery of pictures
If you want to test:
./occ metadata:get <file_id>
[1] https://blurha.sh/