Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: duplicating contacts with the Recently contacted feature #41046

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Fix: duplicating contacts with the Recently contacted feature #41046

merged 1 commit into from
Oct 24, 2023

Conversation

hamza221
Copy link
Contributor

@hamza221 hamza221 commented Oct 22, 2023 •
edited by ChristophWurst
Loading

Summary

TODO

  • ...

Checklist

@hamza221 hamza221 added bug 3. to review Waiting for reviews labels Oct 22, 2023
@hamza221 hamza221 self-assigned this Oct 22, 2023
ChristophWurst
ChristophWurst approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@ChristophWurst ChristophWurst requested review from JohannesGGE and miaulalala and removed request for st3iny October 23, 2023 16:54
@ChristophWurst
Copy link
Member

/backport to stable27

@ChristophWurst
Copy link
Member

/backport to stable26

JohannesGGE
JohannesGGE approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@JohannesGGE JohannesGGE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@ChristophWurst ChristophWurst added 2. developing Work in progress 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews 2. developing Work in progress labels Oct 24, 2023
miaulalala
miaulalala approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drone seems to be having a wobble 😬

@hamza221 hamza221 force-pushed the fix/recently-contacted-duplicates branch from eceb546 to 6ab7691 Compare October 24, 2023 11:04
@ChristophWurst ChristophWurst merged commit 2e25247 into master Oct 24, 2023
37 of 39 checks passed
@ChristophWurst ChristophWurst deleted the fix/recently-contacted-duplicates branch October 24, 2023 18:45
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Oct 24, 2023
Merged
@ChristophWurst ChristophWurst mentioned this pull request Oct 30, 2023
Closed
8 tasks
@jdaviescoates
Copy link

I'm hoping this will also fix a related issue I'm observing, but I'm wondering if I should create a new issue:

  1. If someone who is in already in my contacts books me using my Cal.com page at https://cal.com/jdaviescoates/quick-chat?duration=30
  2. But they typo their email address whilst doing so
  3. And I then I attempt to add them to the event in Nextcloud Calendar as an attendee using their correct email
  4. Nextcloud emails their recently contacted incorrect email instead of their correct email!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohannesGGE JohannesGGE JohannesGGE approved these changes

@miaulalala miaulalala miaulalala approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

Assignees

@hamza221 hamza221

Labels
4. to release Ready to be released and/or waiting for tests to finish backport-request bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: "Recently contacted" feature creates duplicates in Contacts
5 participants
@hamza221 @ChristophWurst @jdaviescoates @miaulalala @JohannesGGE