-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implements search on null/notnull metadata #41459
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
8eba418
to
b77e16c
Compare
b77e16c
to
5229965
Compare
might be cleaner to just transform the dav operator to |
5229965
to
a091bf0
Compare
Do you mean in the DAV request ? The issue is that we are casting the type of the property here: server/apps/dav/lib/Files/FileSearchBackend.php Lines 418 to 436 in b79a21d
And as the property is used in another comparison in the request, it is assumed to be an integer. So using the appropriate operator would be cleaner I think. |
a091bf0
to
ab03a38
Compare
Pushed 3rdparty changes |
cf5b620
to
1386738
Compare
Signed-off-by: Maxence Lange <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
1386738
to
a93af13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 for the caldav changes
Working on fixing test.
(status was before propstat before) |
8d06f48
to
a1d2ac5
Compare
Signed-off-by: Maxence Lange <[email protected]>
a1d2ac5
to
fbe92d4
Compare
adds new public API -> needs docs |
Add the possiblity to search on null/not null value on metadata.
This is a test-feature for the Photos App.
This PR requires to add this line
in https://github.com/nextcloud/3rdparty/blob/master/icewind/searchdav/src/DAV/QueryParser.php#L78
Need: